Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Notebooks for ASR #7994

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fixes Notebooks for ASR #7994

merged 1 commit into from
Dec 7, 2023

Conversation

titu1994
Copy link
Collaborator

@titu1994 titu1994 commented Dec 7, 2023

What does this PR do ?

Notebook fixes

Collection: [ASR]

Changelog

  • Update Librosa signature to use only kwargs

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@titu1994
Fix librosa issue
cbc6249 
Signed-off-by: smajumdar <[email protected]>
@titu1994 titu1994 changed the base branch from main to r1.22.0 December 7, 2023 18:25
@titu1994 titu1994 merged commit 33b522e into r1.22.0 Dec 7, 2023
12 of 13 checks passed
@titu1994 titu1994 deleted the fixes_nb branch December 7, 2023 18:26
github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
@titu1994 @web-flow
Fix librosa issue (#7994)
0be32e8 
Signed-off-by: smajumdar <[email protected]>
titu1994 added a commit that referenced this pull request Dec 7, 2023
@github-actions @titu1994
Fix librosa issue (#7994) (#7995)
25f066f 
Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
pzelasko pushed a commit to pzelasko/NeMo that referenced this pull request Jan 3, 2024
@github-actions @titu1994 @pzelasko
Fix librosa issue (NVIDIA#7994) (NVIDIA#7995)
682ca6b 
Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
@github-actions @titu1994 @sashameister
Fix librosa issue (NVIDIA#7994) (NVIDIA#7995)
d6f42ab 
Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Signed-off-by: Sasha Meister <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
@github-actions @titu1994
Fix librosa issue (NVIDIA#7994) (NVIDIA#7995)
0ace469 
Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ASR CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@titu1994