Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vad & speech command tutorial - onnx #7671

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Fix vad & speech command tutorial - onnx #7671

merged 2 commits into from
Oct 10, 2023

Conversation

fayejf
Copy link
Collaborator

@fayejf fayejf commented Oct 10, 2023

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: fayejf <[email protected]>
Signed-off-by: fayejf <[email protected]>
@fayejf fayejf requested a review from titu1994 October 10, 2023 10:35
@github-actions github-actions bot added the ASR label Oct 10, 2023
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@titu1994 titu1994 merged commit b938bf4 into r1.21.0 Oct 10, 2023
10 checks passed
@titu1994 titu1994 deleted the fix_vad_tutorial branch October 10, 2023 16:02
github-actions bot pushed a commit that referenced this pull request Oct 10, 2023
* fix vad onnx

Signed-off-by: fayejf <[email protected]>

* fix mbn onnx

Signed-off-by: fayejf <[email protected]>

---------

Signed-off-by: fayejf <[email protected]>
titu1994 pushed a commit that referenced this pull request Oct 10, 2023
* fix vad onnx



* fix mbn onnx



---------

Signed-off-by: fayejf <[email protected]>
Co-authored-by: fayejf <[email protected]>
erastorgueva-nv pushed a commit to erastorgueva-nv/NeMo that referenced this pull request Oct 11, 2023
* fix vad onnx



* fix mbn onnx



---------

Signed-off-by: fayejf <[email protected]>
Co-authored-by: fayejf <[email protected]>

Signed-off-by: Elena Rastorgueva <[email protected]>
@fayejf fayejf mentioned this pull request Oct 12, 2023
8 tasks
@github-actions github-actions bot mentioned this pull request Oct 12, 2023
8 tasks
yaoyu-33 pushed a commit that referenced this pull request Oct 16, 2023
* fix vad onnx



* fix mbn onnx



---------

Signed-off-by: fayejf <[email protected]>
Co-authored-by: fayejf <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* fix vad onnx



* fix mbn onnx



---------

Signed-off-by: fayejf <[email protected]>
Co-authored-by: fayejf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants