Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEFT needs mp config propagated for dist ckpt #7589

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

ericharper
Copy link
Collaborator

What does this PR do ?

Updates the base model config so it will use the right mp config.

Collection: NLP

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: eharper <[email protected]>
@github-actions github-actions bot added the NLP label Sep 30, 2023
@ericharper ericharper marked this pull request as ready for review October 2, 2023 17:26
@ericharper ericharper changed the title PEFT needs mp config propagated for dist kept PEFT needs mp config propagated for dist ckpt Oct 2, 2023
Copy link
Collaborator

@aklife97 aklife97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@aklife97 aklife97 merged commit d64edf9 into r1.21.0 Oct 2, 2023
10 checks passed
@aklife97 aklife97 deleted the propagate_mp_config branch October 2, 2023 17:39
github-actions bot pushed a commit that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants