Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick PR #7003 #7441

Merged
merged 11 commits into from
Sep 18, 2023

Conversation

jbaczek
Copy link
Collaborator

@jbaczek jbaczek commented Sep 14, 2023

This is a cherry pick from the main branch, rebased to r.1.20.0_pt_23.09

@github-actions github-actions bot added core Changes to NeMo Core NLP labels Sep 14, 2023
@jbaczek jbaczek force-pushed the jbaczek/update_tp_conf_rework branch from 7d6c338 to 08b35b5 Compare September 18, 2023 12:58
@layalir layalir merged commit 18701b0 into NVIDIA:r1.20.0_pt_23.09 Sep 18, 2023
6 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 18, 2023
* Pass tp config via hydra

Signed-off-by: Jan Baczek <[email protected]>

* Remove self.ub_cfgs field - it isn't used anywhere else

Signed-off-by: Jan Baczek <[email protected]>

* Allow tp_overlap tree substitution in hydra config

Signed-off-by: Jan Baczek <[email protected]>

* Add warning in case of usage of the default tp config

Signed-off-by: Jan Baczek <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: Jan Baczek <[email protected]>

* Change warning message

Signed-off-by: Jan Baczek <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: Jan Baczek <[email protected]>

* Add compute capability resolver

Signed-off-by: Jan Baczek <[email protected]>

* Bugfix

Signed-off-by: Jan Baczek <[email protected]>

* Fix cherry pick

Signed-off-by: Jan Baczek <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Jan Baczek <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
erhoo82 pushed a commit that referenced this pull request Oct 24, 2023
* Pass tp config via hydra

Signed-off-by: Jan Baczek <[email protected]>

* Remove self.ub_cfgs field - it isn't used anywhere else

Signed-off-by: Jan Baczek <[email protected]>

* Allow tp_overlap tree substitution in hydra config

Signed-off-by: Jan Baczek <[email protected]>

* Add warning in case of usage of the default tp config

Signed-off-by: Jan Baczek <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: Jan Baczek <[email protected]>

* Change warning message

Signed-off-by: Jan Baczek <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: Jan Baczek <[email protected]>

* Add compute capability resolver

Signed-off-by: Jan Baczek <[email protected]>

* Bugfix

Signed-off-by: Jan Baczek <[email protected]>

* Fix cherry pick

Signed-off-by: Jan Baczek <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Jan Baczek <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to NeMo Core NLP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants