Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface to enable SHARP #7391

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

erhoo82
Copy link
Collaborator

@erhoo82 erhoo82 commented Sep 7, 2023

What does this PR do ?

Pass knob to enable SHARP to M-Core

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Sep 7, 2023
@ericharper ericharper merged commit 2e8796a into r1.20.0_pt_23.09 Sep 8, 2023
11 of 12 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 8, 2023
erhoo82 added a commit that referenced this pull request Oct 24, 2023
erhoo82 added a commit that referenced this pull request Oct 24, 2023
erhoo82 added a commit that referenced this pull request Nov 30, 2023
erhoo82 added a commit that referenced this pull request Dec 9, 2023
Replace loss_mean bcast with send/recv from the last rank to the first rank for logging

Signed-off-by: Sangkug Lym <[email protected]>

Add a default SHARP setting to arg list

Signed-off-by: Sangkug Lym <[email protected]>

cleanup

Signed-off-by: Sangkug Lym <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants