Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust CLI support for PTQ #11421

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Adjust CLI support for PTQ #11421

merged 1 commit into from
Nov 27, 2024

Conversation

janekl
Copy link
Collaborator

@janekl janekl commented Nov 27, 2024

What does this PR do ?

Adjust CLI support for PTQ based on NVIDIA/NeMo-Run#118 (prerequisite).

Collection: LLM

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# With default quantization_config
nemo llm ptq nemo_checkpoint=/models/Llama-3-70b \
  calib_tp=8 \
  export_config.inference_tensor_parallel=2 \
  export_config.path=/models/Llama-3-70b-FP8

# Changing quantization_config
nemo llm ptq nemo_checkpoint=/models/Llama-3-70b \
  calib_tp=8 \
  export_config.inference_tensor_parallel=1 \
  export_config.path=/models/Llama-3-70b-INT4_AWQ \
  quantization_config.algorithm=int4_awq

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.llm.api
nemo/collections/llm/api.py:601:0: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.95/10

Thank you for improving NeMo's documentation!

Copy link
Contributor

[🤖]: Hi @janekl 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@janekl janekl merged commit 748a592 into main Nov 27, 2024
335 of 635 checks passed
@janekl janekl deleted the jlasek/ptq_cli_extra branch November 27, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants