Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "update hypothesis when passed through cfg" #11373

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

pablo-garay
Copy link
Collaborator

Reverts #11366

Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.asr.models.ctc_models
nemo/collections/asr/models/ctc_models.py:195:0: C0301: Line too long (120/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:196:0: C0301: Line too long (120/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:812:0: C0301: Line too long (133/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:818:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:819:0: C0301: Line too long (143/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:825:0: C0301: Line too long (139/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:826:0: C0301: Line too long (141/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:832:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:833:0: C0301: Line too long (143/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:839:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:840:0: C0301: Line too long (143/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:846:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:847:0: C0301: Line too long (143/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:853:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:854:0: C0301: Line too long (143/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:860:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:861:0: C0301: Line too long (143/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:867:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:868:0: C0301: Line too long (143/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:874:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:875:0: C0301: Line too long (143/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:881:0: C0301: Line too long (139/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:882:0: C0301: Line too long (141/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:888:0: C0301: Line too long (151/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:889:0: C0301: Line too long (162/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:896:0: C0301: Line too long (151/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:897:0: C0301: Line too long (162/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:903:0: C0301: Line too long (139/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:904:0: C0301: Line too long (146/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:544:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/ctc_models.py:601:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/ctc_models.py:619:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/ctc_models.py:661:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/ctc_models.py:679:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/ctc_models.py:915:4: C0116: Missing function or method docstring (missing-function-docstring)
************* Module nemo.collections.asr.models.rnnt_models
nemo/collections/asr/models/rnnt_models.py:1084:0: C0301: Line too long (164/119) (line-too-long)
nemo/collections/asr/models/rnnt_models.py:1085:0: C0301: Line too long (166/119) (line-too-long)
nemo/collections/asr/models/rnnt_models.py:230:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/rnnt_models.py:705:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/rnnt_models.py:803:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/rnnt_models.py:820:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/rnnt_models.py:888:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/rnnt_models.py:896:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/rnnt_models.py:1061:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/rnnt_models.py:1092:4: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.54/10

Thank you for improving NeMo's documentation!

@pablo-garay pablo-garay enabled auto-merge (squash) November 22, 2024 02:41
Copy link
Contributor

[🤖]: Hi @pablo-garay 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@pablo-garay pablo-garay merged commit e731d48 into main Nov 22, 2024
173 of 174 checks passed
@pablo-garay pablo-garay deleted the revert-11366-fix_transcribe-speech branch November 22, 2024 04:03
ananthsub pushed a commit to ananthsub/NeMo that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants