Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeMo-UX: Mistral/mixtral peft ci test #11094

Merged
merged 12 commits into from
Nov 1, 2024
Merged

Conversation

akoumpa
Copy link
Member

@akoumpa akoumpa commented Oct 30, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the CI label Oct 30, 2024
@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_peft_fix_cpl branch from f18fe26 to 66a635c Compare October 30, 2024 07:19
tests/collections/llm/lora_mistralai.py Dismissed Show dismissed Hide dismissed
@akoumpa akoumpa changed the title add mistral/mixtral peft ci test Nemo-UX: Mistral/mixtral peft ci test Oct 30, 2024
@akoumpa akoumpa changed the title Nemo-UX: Mistral/mixtral peft ci test NeMo-UX: Mistral/mixtral peft ci test Oct 30, 2024
@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_peft_fix_cpl branch from ce41fb9 to 9e2c05a Compare October 30, 2024 08:06
@akoumpa akoumpa added Run CICD and removed Run CICD labels Oct 30, 2024
@akoumpa akoumpa marked this pull request as ready for review October 30, 2024 12:11
@akoumpa akoumpa added Run CICD and removed Run CICD labels Oct 30, 2024
@akoumpa akoumpa requested a review from ko3n1g October 30, 2024 13:02
Copy link
Collaborator

@ko3n1g ko3n1g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more and we're good to go

.github/workflows/cicd-main.yml Outdated Show resolved Hide resolved
ko3n1g
ko3n1g previously approved these changes Oct 30, 2024
@akoumpa akoumpa added Run CICD and removed Run CICD labels Oct 30, 2024
@akoumpa akoumpa enabled auto-merge (squash) October 30, 2024 13:51
@akoumpa akoumpa added Run CICD and removed Run CICD labels Oct 30, 2024
@akoumpa akoumpa added Run CICD and removed Run CICD labels Oct 31, 2024
@akoumpa akoumpa marked this pull request as draft October 31, 2024 13:18
auto-merge was automatically disabled October 31, 2024 13:18

Pull request was converted to draft

akoumpa and others added 9 commits October 31, 2024 23:51
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Co-authored-by: oliver könig <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_peft_fix_cpl branch from dc7d027 to 582012f Compare November 1, 2024 06:51
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa added Run CICD and removed Run CICD labels Nov 1, 2024
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa added Run CICD and removed Run CICD labels Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

[🤖]: Hi @akoumpa 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@akoumpa akoumpa marked this pull request as ready for review November 1, 2024 11:22
@akoumpa akoumpa requested a review from ko3n1g November 1, 2024 11:23
@ko3n1g ko3n1g merged commit ba2b96d into main Nov 1, 2024
162 of 163 checks passed
@ko3n1g ko3n1g deleted the akoumparouli/nemo_ux_peft_fix_cpl branch November 1, 2024 12:36
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* add mistral/mixtral peft ci test

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add mistral/mixtral peft ci test

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add mistral tp2

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: akoumpa <[email protected]>

* add tests to NEMO_CICD_Test

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Update .github/workflows/cicd-main.yml

Co-authored-by: oliver könig <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix params

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* rm devices arg

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add --dist-opt arg

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add tp=2 mixtral

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add ep test

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

---------

Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: akoumpa <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Co-authored-by: akoumpa <[email protected]>
Co-authored-by: oliver könig <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
lilyw97 pushed a commit to lilyw97/NeMo that referenced this pull request Nov 13, 2024
* add mistral/mixtral peft ci test

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add mistral/mixtral peft ci test

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add mistral tp2

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: akoumpa <[email protected]>

* add tests to NEMO_CICD_Test

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Update .github/workflows/cicd-main.yml

Co-authored-by: oliver könig <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix params

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* rm devices arg

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add --dist-opt arg

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add tp=2 mixtral

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add ep test

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

---------

Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: akoumpa <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Co-authored-by: akoumpa <[email protected]>
Co-authored-by: oliver könig <[email protected]>
HuiyingLi pushed a commit to HuiyingLi/NeMo that referenced this pull request Nov 15, 2024
* add mistral/mixtral peft ci test

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add mistral/mixtral peft ci test

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add mistral tp2

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: akoumpa <[email protected]>

* add tests to NEMO_CICD_Test

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Update .github/workflows/cicd-main.yml

Co-authored-by: oliver könig <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix params

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* rm devices arg

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add --dist-opt arg

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add tp=2 mixtral

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add ep test

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

---------

Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: akoumpa <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Co-authored-by: akoumpa <[email protected]>
Co-authored-by: oliver könig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants