Add copyright check #11048
Merged
Add copyright check #11048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IA/NeMo into pagaray/add_copyright_check
|
Sample execution (with more files with issues prior to change): https://github.com/NVIDIA/NeMo/actions/runs/11528195110/job/32094993197?pr=11048 |
|
After copyright notices were added, the copyright check rightfully passes |
ko3n1g
requested changes
Oct 29, 2024
| path: ${{ github.run_id }} | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Run on change-set |
There was a problem hiding this comment.
This step does not run on the change-set, it actually scans all files for missing copy-right note. But I think that's not an issue, since we already know that all files in main have this notice so for new PRs it's fine to check all files. How about we name this step like this instead?:
Suggested change
| - name: Run on change-set | |
| - name: All files have copyright notice |
There was a problem hiding this comment.
SG good suggestion
…IA/NeMo into pagaray/add_copyright_check
ko3n1g
approved these changes
Oct 29, 2024
ko3n1g
requested changes
Oct 29, 2024
ko3n1g
approved these changes
Oct 29, 2024
|
Changes do not affect CI , so wont run CI |
akoumpa
pushed a commit
that referenced
this pull request
Oct 29, 2024
* check for copyright * Copyright check * Copyright check * Copyright check * Exclude path * Exclude path * account for other license types * account for other license types * account for other license types * account for other license types * Ignore __init__.py files * Ignore __init__.py files * Ignore __init__.py files * Ignore __init__.py files * Change job name
akoumpa
pushed a commit
that referenced
this pull request
Oct 29, 2024
* check for copyright * Copyright check * Copyright check * Copyright check * Exclude path * Exclude path * account for other license types * account for other license types * account for other license types * account for other license types * Ignore __init__.py files * Ignore __init__.py files * Ignore __init__.py files * Ignore __init__.py files * Change job name Signed-off-by: Alexandros Koumparoulis <[email protected]>
akoumpa
pushed a commit
that referenced
this pull request
Oct 30, 2024
* check for copyright * Copyright check * Copyright check * Copyright check * Exclude path * Exclude path * account for other license types * account for other license types * account for other license types * account for other license types * Ignore __init__.py files * Ignore __init__.py files * Ignore __init__.py files * Ignore __init__.py files * Change job name Signed-off-by: Alexandros Koumparoulis <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* check for copyright * Copyright check * Copyright check * Copyright check * Exclude path * Exclude path * account for other license types * account for other license types * account for other license types * account for other license types * Ignore __init__.py files * Ignore __init__.py files * Ignore __init__.py files * Ignore __init__.py files * Change job name Signed-off-by: Hainan Xu <[email protected]>
lilyw97
pushed a commit
to lilyw97/NeMo
that referenced
this pull request
Nov 13, 2024
* check for copyright * Copyright check * Copyright check * Copyright check * Exclude path * Exclude path * account for other license types * account for other license types * account for other license types * account for other license types * Ignore __init__.py files * Ignore __init__.py files * Ignore __init__.py files * Ignore __init__.py files * Change job name
HuiyingLi
pushed a commit
to HuiyingLi/NeMo
that referenced
this pull request
Nov 15, 2024
* check for copyright * Copyright check * Copyright check * Copyright check * Exclude path * Exclude path * account for other license types * account for other license types * account for other license types * account for other license types * Ignore __init__.py files * Ignore __init__.py files * Ignore __init__.py files * Ignore __init__.py files * Change job name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add copyright check
Sample execution #1 (expected to fail):
https://github.com/NVIDIA/NeMo/actions/runs/11563980809/job/32188323290?pr=11048
Sample execution (with more files with issues prior to change) #2 (expected to fail): https://github.com/NVIDIA/NeMo/actions/runs/11528195110/job/32094993197?pr=11048
After copyright notices were added, the copyright check rightfully passes
https://github.com/NVIDIA/NeMo/actions/runs/11564887593/job/32190934995?pr=11048