Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Send team alerts on specific keywords #10986

Merged
merged 3 commits into from
Oct 27, 2024

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Oct 22, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the CI label Oct 22, 2024
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Oct 23, 2024
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/team-alerts-on-keywords branch from 893be8e to 8a1be96 Compare October 23, 2024 15:31
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Oct 23, 2024
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/team-alerts-on-keywords branch from 178b178 to 39adda0 Compare October 25, 2024 08:16
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Oct 25, 2024
@ko3n1g ko3n1g marked this pull request as ready for review October 25, 2024 09:56
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/team-alerts-on-keywords branch from 0b636b9 to 8c8f960 Compare October 25, 2024 09:56
f
Signed-off-by: Oliver Koenig <[email protected]>
Copy link
Collaborator

@thomasdhc thomasdhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ko3n1g ko3n1g enabled auto-merge (squash) October 25, 2024 21:10
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Oct 25, 2024
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Oct 26, 2024
Copy link
Contributor

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@ko3n1g ko3n1g merged commit 0c5f5fb into main Oct 27, 2024
293 of 295 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/team-alerts-on-keywords branch October 27, 2024 12:15
titu1994 pushed a commit that referenced this pull request Oct 28, 2024
* ci: Send team alerts on specific keywords

Signed-off-by: Oliver Koenig <[email protected]>

* f

Signed-off-by: Oliver Koenig <[email protected]>

---------

Signed-off-by: Oliver Koenig <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* ci: Send team alerts on specific keywords

Signed-off-by: Oliver Koenig <[email protected]>

* f

Signed-off-by: Oliver Koenig <[email protected]>

---------

Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
HuiyingLi pushed a commit to HuiyingLi/NeMo that referenced this pull request Nov 15, 2024
* ci: Send team alerts on specific keywords

Signed-off-by: Oliver Koenig <[email protected]>

* f

Signed-off-by: Oliver Koenig <[email protected]>

---------

Signed-off-by: Oliver Koenig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants