Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix in gemma 2 ckpt conversion to support Gemma 2B #10959

Conversation

shashank3959
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Change uses "sliding_window" arg in HF ckpt config to inform window_size. This makes it compatible with all sizes: 2B, 9B and 27B
  • Gemma 2 9B, and Gemma 2 27B HF ckpts have "sliding_window" and "sliding_window_size" both set to 4096
  • Gemma 2 2B config.json in HF ckpt does not have a "sliding_window_size" arg, and only has "sliding_window"

Usage

  • You can potentially add a usage example below
python3 /opt/NeMo/scripts/checkpoint_converters/convert_gemma_hf_to_nemo.py \
--input_name_or_path /path/to/gemma2/checkpoints/hf/2b \
--output_path /path/to/gemma2-2b.nemo \
--tokenizer_path /path/to/tokenizer.model \
[--cpu]

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

* Forward pass in Gemma 2 passes runtime_gather_output which
it needs for ColumnParallelLinear
* Leads to error in finetuning gemma 2 2b without it

Signed-off-by: Shashank Verma <[email protected]>
* Change uses "sliding_window" arg in HF ckpt config to inform
  window_size. This makes it compatible with all sizes: 2B, 9B and 27B
* Gemma 2 9B, and Gemma 2 27B HF ckpts have "sliding_window"
and "sliding_window_size" both set to 4096
* Gemma 2 2B config.json in HF ckpt does not have
a "sliding_window_size" arg, and only has "sliding_window"

Signed-off-by: Shashank Verma <[email protected]>
cuichenx
cuichenx previously approved these changes Oct 21, 2024
Copy link
Collaborator

@cuichenx cuichenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cuichenx
Copy link
Collaborator

Please remove overlapping change with #10958 or combine the two PRs

Signed-off-by: Chen Cui <[email protected]>
Copy link
Contributor

github-actions bot commented Nov 7, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Nov 7, 2024
Copy link
Contributor

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants