Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Lhotse online augmentation tutorial for SE #10944

Merged
merged 4 commits into from
Oct 26, 2024

Conversation

nasretdinovr
Copy link
Collaborator

What does this PR do ?

Aim of this PR is to push a tutorial of training speech enhancement models with online augmentation to NeMo.

Collection: audio

Changelog

  • New notebook file with the tutorial added to tutorials/audio/speech_enhancement
  • New configuration file for the training "masking" model with online augmentation added to the examples/audio/conf/
  • Problem with the RIR online augmentation is fixed in nemo/collections/audio/data/audio_to_audio_lhotse.py

Usage

All instructions are in the notebook examples/audio/conf/masking_with_online_augmentation.yaml

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Collaborator

@anteju anteju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

LGTM, but let's wait for CI to complete.

Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool!

@nasretdinovr nasretdinovr merged commit 60b4ac7 into NVIDIA:main Oct 26, 2024
152 of 154 checks passed
titu1994 pushed a commit that referenced this pull request Oct 28, 2024
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
HuiyingLi pushed a commit to HuiyingLi/NeMo that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants