Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing #65

Merged
merged 26 commits into from
Mar 5, 2024
Merged

Testing #65

merged 26 commits into from
Mar 5, 2024

Conversation

JunAishima
Copy link

  • Fix partially implemented testing
  • Fix deprecated pymongo methods
  • Fix packaging for schemas

@JunAishima
add testing mode, same as conftrak/analysisstore
1a4f7ad
@JunAishima
add workflow and requirements-dev to enable testing to run
4230081
@JunAishima
fix deprecated collection command
a4766b1
@JunAishima
finish replacing conn with our fixture astore_client
4f3d6a0
@JunAishima
fix naming of fixture objects
7921c51 
 * fix to amostra, since that is what we are testing here
@JunAishima
initial fix of tests
720b3a7 
 * methods for instantiating and calling functions is different
   in the tests compared to actual amostra client code, so
   are being fixed
 * still some issues with return types, etc.
@JunAishima
fix tests that return lists instead of iterators
002ce24
@JunAishima
remove duplication checks
16a24dd 
 * cross-checking with analysisstore and conftrak, as well as how
   the code and mongodb queries work, there has not been duplication
   checks implemented
@JunAishima
remove nonsense test
71e22a5 
 * with the current amostra client does not need instantiation, so
   remove the test entirely
@JunAishima
fix tests to use our fixtures
692d924
@JunAishima
fix tests for fixtures
5d30511
@JunAishima
fix tests to use amostra_client properly
d6ab6b4
@JunAishima
remove test
4526445 
 * does not appear to be used at all in
   current code
@JunAishima
remove setup and teardown functions
9cd7a71 
 * using pytest fixtures so no longer necessary
@JunAishima
make local amostra client fixtures and use them
f8691bd 
 * TODO need to clear the cache directory after all
   testing is done
@JunAishima
improve local fixtures to clear cache directory
5277b63 
 * using Path.expanduser() gave the correct expansion
   of the path used in the local files variable
@JunAishima
fix small issues with tests
540088f
@JunAishima
fix typo
bd9a0ab
@JunAishima
ensure schemas gets packaged
8244b46
@JunAishima
fix tests
d43300a 
 * call correct function
 * take first item of returned list
@JunAishima
fix method call and return value of list for tests
0d172c4
@JunAishima
fix tests to use amostra_client
75b5031 
 * instead of SampleReference, RequestReference,
   ContainerReference
 * this also results in change to tests since *Reference.find()
   returns a generator, while amostra_client.find_*() returns
   a list derived from the generator
@JunAishima
remove mock - not needed
d6b9329
@JunAishima
put temporary files into tmp
d3cd2b7 
 * do not potentially put files into userspace
@JunAishima
restore original directory for amostra_files
17a5093
@JunAishima
use local_files param for Local*Reference object instantiation
d967239
@gwbischof gwbischof merged commit 3253bc2 into NSLS-II:v0.2.x Mar 5, 2024
12 checks passed
@JunAishima JunAishima mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JunAishima @gwbischof