Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dask get_fccd_images #94

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: Dask get_fccd_images #94

wants to merge 6 commits into from

Conversation

maffettone
Copy link
Contributor

Add Dask versions of the C functions fastccd::correct_fccd_images and image::rotate90.

This should enable us to do all of the modifications for loading in chunks, and grab 1 chunk at a time from tiled to load. The C functions are parallelized; however, they need to load the full arrays into RAM.

@maffettone maffettone marked this pull request as ready for review June 25, 2024 21:44
Copy link
Contributor

@padraic-shafer padraic-shafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks very good. I've included a few suggestions, and I think I spotted a logic error in the rotation sense used by da.rotate90().

csxtools/image/dask.py Outdated Show resolved Hide resolved
csxtools/fastccd/dask.py Outdated Show resolved Hide resolved
csxtools/fastccd/dask.py Outdated Show resolved Hide resolved
csxtools/fastccd/dask.py Outdated Show resolved Hide resolved
csxtools/fastccd/dask.py Outdated Show resolved Hide resolved
csxtools/fastccd/dask.py Outdated Show resolved Hide resolved
@maffettone
Copy link
Contributor Author

Ah good catch! Thanks!

@padraic-shafer
Copy link
Contributor

@ambarb This is ready for review + merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants