MNT: Drop travis for GHA #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrakitin
reviewed
Nov 3, 2023
There was a problem hiding this comment.
Looks good overall, thanks for the effort, @maffettone!
Maybe we could limit the version of NumPy in the requirements to avoid test failures?
What's the most recent version of NumPy where it works? We now have numpy=1.24.4 in our latest conda envs 2023-3.2. The latest version is https://pypi.org/project/numpy/1.26.1/.
ambarb
requested changes
Nov 3, 2023
This was referenced Nov 3, 2023
- Add min supported version - Add long description from README - Add short description - Fix URL for repo
|
@mrakitin Looks like the build for the test container has I updated the |
|
Im good to merge once @mrakitin concurs. Thanks for fixing these cosmetic things on top of improving CI and other such engineering aspects. |
mrakitin
reviewed
Nov 8, 2023
Co-authored-by: Max Rakitin <[email protected]>
mrakitin
approved these changes
Nov 8, 2023
ambarb
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Travis for CI/CD and replace with GHA. Actions for the following were added:
run_tests.pyscript that was run by Travis.Notably, this shows some lint that wasn't highlighted by Travis (Flake8), and a couple of failing unit tests...