Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engage75 change user #232

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Engage75 change user #232

wants to merge 2 commits into from

Conversation

jeisenman23
Copy link
Collaborator

No description provided.

@@ -1,4 +1,5 @@
import json
# from ..client.views import common_timezones
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment

@hannamocha
Copy link
Collaborator

These changes don't reflect the mockup, but looking at the user pages again I don't think there's a need to combine the change password page and the user detail page. Seems ideal to keep them separate and I forget the context of that thought process.

Maybe just add the ability for them to edit fist name and last name as well and call it good if James/Tom agree?
https://www.figma.com/design/YMXjpOGObjPVUdsuAJz0EN/Engage-Profile-Page?node-id=0-1&t=iMrWGxAW5WOv7vHt-1

@hannamocha
Copy link
Collaborator

Confirmed with Jordan today, he's going to add first and last name editability to this and make a separate ticket to add email notifications down the line. Keeping the change password page separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants