-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding super controller #22
Open
paulf81
wants to merge
77
commits into
NREL:master
Choose a base branch
from
paulf81:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the new ssc functionality and check backward compatability
…ide turbineArrayProperties.
…er in the ADM log file.
…MW turbine controller settings to PIDSC and yawSC.
…r correctness of inputs, more generic.
Implement timeTableSSC as an improvement to SCSimple
…C turbine controller. (This could have also been done in PIDSC)
…he zeroMQ superController implementation. This is currently hardcoded for Peregrine, and works if you have loaded the module through: module load zeromq/4.2.2/gcc.
…y still in development phase.
…ers. This should facilitate for about 1k+ floats to be sent around. This should suffice for SC inputs and outputs.
…ome comments to the zeroMQ superController.
…es some debugging, but works well overall.
Update zeromqSSC implementation to a more general implementation. Mov…
…sh at end of file during SOWFA compilation. Furthermore, replace all tabs with spaces for consistency and readability.
Update options compilation file to remove warning message for backsla…
… will allow multiple connections on the same node/network.
Add torqueSC option (directly specifying generator torque through the ZMQ interface)
Add the torqueSC controller module, in which the generator torque is directly specified from the ZMQ interface (e.g., MATLAB or Python). Basically, this means the turbine controller can now be programmed in MATLAB or Python.
…ocessed case files
… not one wants to compile SOWFA with the ZeroMQ module.
…s makes the solution more modular
… are general and can be used also with ALM and ALMAdvanced. This is in preparation for the ALMAdvanced SSC implementation
Merge changes from master
Merge changes from master branch
Bug fix for yaw actions in ALMAdvanced
Bartdoekemeijer
force-pushed
the
master
branch
2 times, most recently
from
December 21, 2018 09:51
657c98e
to
3e3c264
Compare
Bug fixes to avoid turbines from rotating a full circle to reach a small (but negative) deltaNacYaw setpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Matt/SOWFA team, Bart and I propose this fork to include super controller capabilities into SOWFA. Critically, everything should work the same as before, but some new options are available to include super controllers into ADM simulations.
Bart recently merged all latest SOWFA commits, so this is currently only ahead of SOWFA and should be not to complex to pull in.