Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghx defaults standardization #604

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

atpham88
Copy link
Collaborator

Please check if the PR fulfills these requirements

  • CHANGELOG.md is updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

(Bug fix, feature, docs update, ...)

What is the current behavior?

(You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

(What changes might users need to make in their application due to this PR?)

Other information:

hdunham and others added 7 commits July 29, 2024 16:57
ERP outputs endpoint; set reopt_version in meta data programmatically
Merge summary endpoint updates to master
ASHP and summary endpoint updates
Results Table Download Endpoint
@atpham88 atpham88 marked this pull request as ready for review September 30, 2024 04:16
@Bill-Becker Bill-Becker self-requested a review October 2, 2024 22:07
@Bill-Becker
Copy link
Collaborator

@atpham88 I just realized we'll need to update the default values displayed in the web tool to match these. Can you let Erika know? Also, do we need to update the User Manual? If so, coordinate with Linda on how to make those updates, and then Erika will upload the latest version of the User Manual. Or, we could wait until the other defaults are updated and do all of them at once. That depends on your timeline for making these updates.

@atpham88
Copy link
Collaborator Author

@Bill-Becker Thanks Bill for reminding me of this. I just sent Erika a message about this. I can coordinate with Linda after we have these values updated in the web tool. It's not a rush on my end so we can probably wait to have a big default update at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants