Add gnu compiler support #32
Conversation
build.sh
Outdated
| @@ -13,7 +13,7 @@ OPTIONS | |||
| (e.g. hera | jet | hercules) | |||
| -c, --compiler=COMPILER | |||
| compiler to use; default depends on platform | |||
| (e.g. intel | gnu | cray | gccgfortran) | |||
| (e.g. intel | gcc) | |||
There was a problem hiding this comment.
Update to the help message for the compiler. Currently only supporting intel and gcc. If we want users to call gccgfortran the build script names will need to be updated.
gcc's build target is gfortran for the MPAS-Model.
| else | ||
| echo "Unsupported compiler: ${COMPILER}" | ||
| exit 1 |
There was a problem hiding this comment.
If intel or gcc is not supplied for the compiler than an error message will appear to the user to set the correct settings, i.e.
PLATFORM(MACHINE)=hercules
COMPILER=gnu
ERROR: module file does not exist for platform/compiler
MODULE_FILE=build_hercules_gnu
PLATFORM=hercules
COMPILER=gnu
Please make sure PLATFORM and COMPILER are set correctly
Usage: ./build.sh --platform=PLATFORM [OPTIONS]
OPTIONS
-h, --help
show this help guide
-p, --platform=PLATFORM
name of machine you are building on
(e.g. hera | jet | hercules)
-c, --compiler=COMPILER
compiler to use; default depends on platform
(e.g. intel | gcc)
....
....
There was a problem hiding this comment.
We should have it set so that someone could run with -c=gnu and have it run with the gfortran build
| mpas: | ||
| execution: | ||
| batchargs: | ||
| partition: hera |
There was a problem hiding this comment.
If the partition is not included for hera, then it will pass the build process, but will break on the rocotorun ... command for the forecast task. Stating the partition: None
README.md
Outdated
| Currently Hera and Jet are the only platforms with GNU Compiler support. To run the default build script with a specified compiler: | ||
|
|
||
| `./build.sh -p=<platform> -c=<compiler>` | ||
|
|
There was a problem hiding this comment.
Add content for GNU Compiler support. Let me know if this is something we want to add to main or it's best left out for now.
There was a problem hiding this comment.
I think this line could potentially be combined with line 22 or rephrased. It sounds a little repetitive right now.
NaureenBharwaniNOAA
requested review from
jderrico-noaa,
christinaholtNOAA and
elcarpenterNOAA
as code owners
Synopsis
Add GNU Compiler support for Hera and Jet.
Tested on Hera and Jet.
Type
Impact
Checklist