Update to GBBPEx v005 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jobs/rocoto/prepchem.sh
Outdated
| @@ -109,12 +109,18 @@ for n in $(seq 1 6); do | |||
| else | |||
|
|
|||
| if [ ${SYEAR} -eq 2016 -o ${emiss_date1} -ge 20230115 ]; then ## JKH - change date | |||
| if [ ${emiss_date1} -ge 20230509 ]; then ## JKH - change date | |||
| if [ [ ${emiss_date1} -ge 20230509 ] && [ ${emiss_date1} -le 20240501 ] ]; then ## JKH - change date | |||
There was a problem hiding this comment.
Suggested change
| if [ [ ${emiss_date1} -ge 20230509 ] && [ ${emiss_date1} -le 20240501 ] ]; then ## JKH - change date | |
| if [[ ${emiss_date1} -ge 20230509 && ${emiss_date1} -le 20240501 ]]; then ## JKH - change date |
There was a problem hiding this comment.
I have updated. How can I do now?
| # SO2=GBBEPx.so2.${SYEAR}${nmonth}${nday}.FV3.${CASE}Grid.tile${n}.bin | ||
| # FRP=meanFRP.${SYEAR}${nmonth}${nday}.FV3.${CASE}Grid.tile${n}.bin | ||
| #fi | ||
| if [ ${SYEAR} -eq 2016 -o ${emiss_date1} -ge 20230115 ]; then ## JKH - change date |
Check warning
Code scanning / shellcheck
Prefer [ p ] || [ q ] as [ p -o q ] is not well defined. Warning
jderrico-noaa
approved these changes
May 3, 2024
jderrico-noaa
approved these changes
May 3, 2024
|
Shell check was successful, so I'm merging this PR |
No, it is has issue. I fixed one more time.
|
|
@jderrico-noaa I think I need to submit one more PR, the previous did not work. |
jderrico-noaa
added a commit
that referenced
this pull request
May 3, 2024
This reverts commit 924deee.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Change characteristics
How has this been tested?
Checklist