Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experiment directory for rt_v17p8_ugwpv1_mynn. #39

Closed
wants to merge 1 commit into from

Conversation

kayeekayee
Copy link
Collaborator

Description

Add experiment directory for rt_v17p8_ugwpv1_mynn.

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

120hrs run completed on Hera: /scratch1/BMC/gsd-fv3-dev/KaYee.Wong/github/gsl_ufs_rt/
Completed all gfsatmprod and waiting for gfsarch to finish.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shellcheck found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@jderrico-noaa
Copy link
Collaborator

I thought the experiment directories were created when the setup script is run, so any changes should be to the script rather than the directories themselves?

@jkhender
Copy link

jkhender commented Feb 6, 2024

This is to save the settings of the experiment directory that is being used for the realtime experiment. For instance, we want to save a copy of the XMLs that are being run since it is the only place they exist. You may also have changes in the configuration files that are different than what are under parm/config/gfs.

Having said that, this experiment directory was created from the gsl_ufs_dev branch before we made changes to the configuration files in gsl_ufs_rt, so we should wait to commit this directory until after we update the version of UFS so we get the updated files.

Ka Yee, we will also need to add the XML files in the realtime directory, including the PyGraf ones.

@jderrico-noaa
Copy link
Collaborator

No longer necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants