Update obs-monitor wcoss2 module. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update wcoss2.lua.
EdwardSafford-NOAA
requested review from
CoryMartin-NOAA,
ADCollard and
kevindougherty-noaa
CoryMartin-NOAA
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some problems updating the obs-mon ve on wcoss2 due mostly to existing issues. These are fixed and I've updated the python version as well. Small changes were required in the
wcoss2.luamodule to complete the ve update.The issue that prompted this fix was that plotting logos still didn't work on wcoss2 despite the recent update to eva. With this change and the rebuilt ve logos (and tight layout) now work on wcoss2.
Closes #53