forked from mom-ocean/MOM6
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ocean lag option, make cap consistent #33
Merged
DeniseWorthen
merged 6 commits into
NOAA-EMC:dev/emc
from
DeniseWorthen:feature/nocold_ncarpr
Sep 9, 2020
Merged
add ocean lag option, make cap consistent #33
DeniseWorthen
merged 6 commits into
NOAA-EMC:dev/emc
from
DeniseWorthen:feature/nocold_ncarpr
Sep 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restart_mode='cmeps' is now 'alarms'. In this case, restart control is via alarms set using restart_n and restart_option. If restart_n is 0 for non-cesm, restart_mode will be set to 'no_alarms'. In this case, restarts will be written only at finalize
All baselines pass; logs posted here |
DeniseWorthen
requested review from
JessicaMeixner-NOAA,
jiandewang and
binli2337
September 9, 2020 11:35
JessicaMeixner-NOAA
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and ufs-s2s regtests passed (ufs-community/ufs-s2s-model#175) so approved!
binli2337
approved these changes
Sep 9, 2020
jiandewang
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look good
jiandewang
pushed a commit
to jiandewang/MOM6
that referenced
this pull request
Jun 17, 2021
Merge in latest updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #32: Adds option to skip coldstart and use ocean lag for startup
Renames restart_mode "cmeps" to "alarms" and "nems" to "no_alarms". This more clearly defines the two modes. This duplicates current functionality.
When restart_mode is "alarms", restart writing will be controlled by the settings of restart_n and restart_option. For non-cesm, intermediate restarts will be written time-stamped and the final restart will not have a timestamp.
When restart_mode is "no_alarms" (ie, restart_n = 0), the restarts will be written only at finalize.
Also includes additional log message cleanup.
No changes are expected to baselines.
Baselines shown on associated ufs-s2s-model PR #175