-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the ConMon to use GSI-monitor shared resources #58
Update the ConMon to use GSI-monitor shared resources #58
Conversation
Begin overhaul of ConMon_config.
Merge branch 'develop' into feature/updt_ConMon_28
Initial changes for use of Mon_config.
Work in progress.
Merge branch 'develop' into feature/updt_ConMon_28
wcoss2 plot updates.
Changes for orion.
More cleanup.
Still more cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes here look fine. However, on a test run, I am seeing a large number of errors being reported from src/Conventional_Monitor/nwprod/conmon_shared/ush/diag2grad_uv_case.sh at lines 116 and 122. I'm guessing the intent is that these lines should be, e.g.
grads_list=`ls *grads*uv*.${run}`
In order to capture the just created files.
There are similar errors at
/data/users/dhuber/gsi-monitor/src/Conventional_Monitor/nwprod/conmon_shared/ush/diag2grad_q_case.sh: 98, 104
and
/data/users/dhuber/gsi-monitor/src/Conventional_Monitor/nwprod/conmon_shared/ush/diag2grad_q_case.sh: 96, 102
If these aren't appropriate for this issue and/or are non-critical, I can open another issue to track them.
Hmmm. That's interesting and a bit distressing. I'll re-run and see if I can reproduce those errors. |
I think I have it figured out. In my test I was able to reproduce the failures to build the So it looks like this isn't really a problem, per se, but warrants additional investigation. The ConMon still has embedded lists of types and subtypes in the scripts. It's possible those lists are out of date, and anyway should be replaced with an external file for better clarity and ease of maintenance. If you agree I'll open two new issues. One will be for the scripts to handle this situation more elegantly, report the situation more clearly, and abort processing the missing type/subtypes sooner in the process flow. The second issue will be to investigate what data types/subtypes are actually expected and which are no longer available, and then create an external type file like the other monitors use. |
@EdwardSafford-NOAA Glad to know everything still works. I think opening a couple of new issues is a good approach. I'll run a test on the plotting routines then wrap up my review. |
I received errors from GrADS that I also received several sets of the following during plothorz.sh
And very similar errors from plothorz_uv.sh. |
dfa5712
to
fa4568a
Compare
The plot issues appear to be connected to missing data. I've worked through plotting for data class q, and when I add a check on for the existence of the necessary data files before firing the GrADS plot scripts, the maskout and missing map file errors are no more. The map files are created when the required data is available. All data types that use GrADS plot script
The affected data types/subtypes are uv229_00, uv280_00, uv281_00, uv282_00, uv284_00, uv287_00. I believe the quickest fix for this is to temporarily disable plots for these data types and open an issue to figure out what's up with There is one other problem related to the analysis and guess files format change from wgrib to wgrib2. This will require change(s) to one or more GrADS plot scripts. I'll work through the remaining data types individually, confirm these changes eliminate the plot errors, and describe the changes fully when I add them to this PR. |
New issues have been opened in connection with problems encountered in this PR. They are: #60 to investigate missing data and move the expected class/type/subtype information out of the plot scripts and into a fix file. |
fa4568a
to
5575305
Compare
7c11d73
to
3052902
Compare
Rm debug statements.
3052902
to
046ff04
Compare
Note that plotting still produces warnings but no longer (in my tests) produces any fatal errors. Expected GrADS warnings include:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this fell off my radar with AMS. I've run a test case and it all looks good to me. Thanks!
@DavidHuber-NOAA no worries! I figured the AMS week was going to be a distraction and set my expectations accordingly. Sure glad to have this one done -- it's been quite the slog. And thanks again for your help. |
Update the ConMon to use the shared DA monitor resources. Remove support for deprecated systems, add support for orion.
Note that, unlike the other DA monitors, the ConMon is not in the global workflow. Data extraction jobs can be started by the
ConMon/data_xtrct/ush/ConMon_DE.sh
script any time after thecnvstat
file is generated.Also note that the
Transfer.sh
script only works on wcoss2.