Allow NUM_CYCLES to be optionally set by command line argument. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add setting num_cycles via command line.
Merge branch 'develop' into feature/num_cycles_38
OznMon changes for NUM_CYCLES.
DavidHuber-NOAA
approved these changes
Oct 31, 2022
| @@ -93,7 +72,7 @@ do | |||
| shift | |||
| done | |||
|
|
|||
| if [[ $nargs -lt 0 || $nargs -gt 9 ]]; then | |||
| if [[ $nargs -lt 0 || $nargs -gt 13 ]]; then | |||
There was a problem hiding this comment.
Should this be 11?
There was a problem hiding this comment.
No, 13 is right. The previous value of 9 was wrong and should have been 11. The options include run, pdate, ncyc, and tank, plus are 2 older, unique options for comparison plotting (comp1, comp2). So total of 12 + suffix is possible.
There was a problem hiding this comment.
Okie dokie. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NUM_CYCLES is defined in the *Mon/config or user settings file and sets the number of cycles used in time series plots. It's sometimes useful to plot specific sources at a different period for time series, while using the default for all others. This change provides a means to easily accomplish that.
Testing was done on Orion, Hera, and wcoss2 confirming both the NUM_CYCLES values with and without command line setting. Time series plots were made for RadMon and OznMon confirming the correct use of NUM_CYCLES.
Note that the MinMon does not create time series plots. Note too that the ConMon is still waiting update to use the shared GSI-monitor resources (#28) and does not plot correctly at the moment. Confirmation of the correct setting of NUM_CYCLES in the ConMon plots was made though.
This completes #38.