-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct c and bmatching to be squared and add separate damping for charm and bottom #140
Conversation
I guess I will also make possible here to have different dampings for bottom and charm |
If someone like @felixhekhorn or @giacomomagni can please run pre-commit it would be good because my pre-commit seems to be broken now |
An you replace uppercase B and C with lowercase for consistency with other keys? |
I didn't look, but does |
I don't believe so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- this is indeed a bug - good you found it!
- we will need to adjust all theory cards, no? adding the two new fields
Yes, can some of you take care of this in |
I can, but we need to discuss if we want to have 0 or 2 |
I would say we should have DAMP: 1 at NLO, NNLO and N3LO because at least the theta we want. Also DAMPPOWERc: 0 at NLO, NNLO and N3LO. Then at NLO I would do DAMPPOWERb: 2, while at NNLO and N3LO I would do DAMPPOWERb: 0 |
Thanks @andreab1997, these setting should be the closer to the old ones, so I suggest we stick to them. |
Okay I'll update them |
Actually, should we do damping in the same way as the old theories. Meaning that I'm not saying this is what we should do was just wondering about it when thinking about what to do with the theorycard for theory 400 in https://github.com/NNPDF/theories_slim/pull/18 |
Yes maybe we should. However in this way it would not be possible anymore to avoid damping completely |
we could abuse the fact that it is an int and say 1: damping with function, 0: damping with theta, -1: all FKs always everywhere or do we consider -1 to be unphysical? (I can't see an obvious reason why we should ...) |
Since the -1 would probably only be a pineko feature for internal/development use and never end up in a final theory that could work, it would just need to be documented somewhere. |
Yes I agree with this! Let me reflect this in pineko |
Please check if this is what we agreed on 90c075d (and also please run pre-commit) |
Co-authored-by: Roy Stegeman <[email protected]>
pretty sure these last changes are fine |
Okay I think this is ready to be merged |
No description provided.