Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct c and bmatching to be squared and add separate damping for charm and bottom #140

Merged
merged 8 commits into from
Dec 1, 2023

Conversation

andreab1997
Copy link
Contributor

No description provided.

@andreab1997
Copy link
Contributor Author

I guess I will also make possible here to have different dampings for bottom and charm

@andreab1997
Copy link
Contributor Author

If someone like @felixhekhorn or @giacomomagni can please run pre-commit it would be good because my pre-commit seems to be broken now

@RoyStegeman
Copy link
Member

An you replace uppercase B and C with lowercase for consistency with other keys?

@RoyStegeman
Copy link
Member

I didn't look, but does tcards_fonll require any changes?

@andreab1997
Copy link
Contributor Author

I didn't look, but does tcards_fonll require any changes?

I don't believe so

@felixhekhorn felixhekhorn added the bug Something isn't working label Dec 1, 2023
@felixhekhorn felixhekhorn linked an issue Dec 1, 2023 that may be closed by this pull request
Copy link
Contributor

@felixhekhorn felixhekhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. this is indeed a bug - good you found it!
  2. we will need to adjust all theory cards, no? adding the two new fields

@andreab1997
Copy link
Contributor Author

  1. this is indeed a bug - good you found it!
  2. we will need to adjust all theory cards, no? adding the two new fields

Yes, can some of you take care of this in theories_slim while I produce the grids and fktables? Otherwise I will do it later

@RoyStegeman
Copy link
Member

RoyStegeman commented Dec 1, 2023

Yes, can some of you take care of this in theories_slim while I produce the grids and fktables? Otherwise I will do it later

I can, but we need to discuss if we want to have 0 or 2 DAMPPOWERb at NNLO and N3LO.

@RoyStegeman RoyStegeman changed the title Correct c and bmatching to be squared Correct c and bmatching to be squared and add separate damping for charm and bottom Dec 1, 2023
@andreab1997
Copy link
Contributor Author

Yes, can some of you take care of this in theories_slim while I produce the grids and fktables? Otherwise I will do it later

I can, but we need to discuss if we want to have 0 or 2 DAMPPOWERb at NNLO and N3LO.

I would say we should have DAMP: 1 at NLO, NNLO and N3LO because at least the theta we want. Also DAMPPOWERc: 0 at NLO, NNLO and N3LO. Then at NLO I would do DAMPPOWERb: 2, while at NNLO and N3LO I would do DAMPPOWERb: 0

@giacomomagni
Copy link
Contributor

Thanks @andreab1997, these setting should be the closer to the old ones, so I suggest we stick to them.

@RoyStegeman
Copy link
Member

Okay I'll update them

@RoyStegeman
Copy link
Member

RoyStegeman commented Dec 1, 2023

Actually, should we do damping in the same way as the old theories. Meaning that DAMP: 0 does only the step function and DAMP: 1 requires also DAMPPOWERc and DAMPPOWERb? This reduces flexibility but keeps the meaning of DAMP more consistent among theories (if I understand the old situation correctly).

I'm not saying this is what we should do was just wondering about it when thinking about what to do with the theorycard for theory 400 in https://github.com/NNPDF/theories_slim/pull/18

@andreab1997
Copy link
Contributor Author

Actually, should we do damping in the same way as the old theories. Meaning that DAMP: 0 does only the step function and DAMP: 1 requires also DAMPPOWERc and DAMPPOWERb? This reduces flexibility but keeps the meaning of DAMP more consistent among theories (if I understand the old situation correctly).

I'm not saying this is what we should do was just wondering about it when thinking about what to do with the theorycard for theory 400 in NNPDF/theories_slim#18

Yes maybe we should. However in this way it would not be possible anymore to avoid damping completely

@felixhekhorn
Copy link
Contributor

However in this way it would not be possible anymore to avoid damping completely

we could abuse the fact that it is an int and say 1: damping with function, 0: damping with theta, -1: all FKs always everywhere

or do we consider -1 to be unphysical? (I can't see an obvious reason why we should ...)

@RoyStegeman
Copy link
Member

Since the -1 would probably only be a pineko feature for internal/development use and never end up in a final theory that could work, it would just need to be documented somewhere.

@andreab1997
Copy link
Contributor Author

andreab1997 commented Dec 1, 2023

However in this way it would not be possible anymore to avoid damping completely

we could abuse the fact that it is an int and say 1: damping with function, 0: damping with theta, -1: all FKs always everywhere

or do we consider -1 to be unphysical? (I can't see an obvious reason why we should ...)

Yes I agree with this! Let me reflect this in pineko

@andreab1997
Copy link
Contributor Author

andreab1997 commented Dec 1, 2023

Please check if this is what we agreed on 90c075d

(and also please run pre-commit)

src/pineko/cli/fonll.py Outdated Show resolved Hide resolved
@RoyStegeman
Copy link
Member

(and also please run pre-commit)

pretty sure these last changes are fine

@RoyStegeman
Copy link
Member

Okay I think this is ready to be merged

@andreab1997 andreab1997 merged commit 68c41e7 into main Dec 1, 2023
5 checks passed
@andreab1997 andreab1997 deleted the correct_damping branch December 1, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a DAMPPOWER per quark
4 participants