-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Reimplement ATLAS_Z0_7TEV_46FB_CC #2204
Conversation
@@ -19,7 +19,7 @@ implemented_observables: | |||
label: ATLAS $Z$ 7 TeV 2011 Central selection | |||
units: '' | |||
process_type: EWK_RAP | |||
tables: [] | |||
tables: [11-13] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be [11, 12, 13]. Then you can use it to loop over in eg filter_utils/get_data_values
instead of having to write three times
with open(...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, tables
should be a Python list specifying the table ID. This will be crucial when we want to remove the rawdata from the remote repository (cc #2199).
def get_data_values(): | ||
""" | ||
returns the central data values in the form of a list. | ||
""" | ||
|
||
data_central = [] | ||
|
||
hepdata_table_1 = f"rawdata/HEPData-ins1502620-v1-Table_11.yaml" | ||
hepdata_table_2 = f"rawdata/HEPData-ins1502620-v1-Table_12.yaml" | ||
hepdata_table_3 = f"rawdata/HEPData-ins1502620-v1-Table_13.yaml" | ||
|
||
with open(hepdata_table_1, 'r') as file: | ||
input_1 = yaml.safe_load(file) | ||
|
||
with open(hepdata_table_2, 'r') as file: | ||
input_2 = yaml.safe_load(file) | ||
|
||
with open(hepdata_table_3, 'r') as file: | ||
input_3 = yaml.safe_load(file) | ||
|
||
values_1 = input_1['dependent_variables'][0]['values'] | ||
values_2 = input_2['dependent_variables'][0]['values'] | ||
values_3 = input_3['dependent_variables'][0]['values'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be a good idea to have get_data_values take a tables list that is read from the metadata and passed from filter/filter_ATLAS_Z0_7TEV_46FB_CC_data_kinematics
def get_kinematics(): | ||
""" | ||
returns the kinematics in the form of a list of dictionaries. | ||
""" | ||
kin = [] | ||
|
||
hepdata_table_1 = f"rawdata/HEPData-ins1502620-v1-Table_11.yaml" | ||
hepdata_table_2 = f"rawdata/HEPData-ins1502620-v1-Table_12.yaml" | ||
hepdata_table_3 = f"rawdata/HEPData-ins1502620-v1-Table_13.yaml" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same idea here, I think that the function could be made simpler by adding a tables to the args
Same, should this be closed? |
Added function to filter_utils.py to produce data.yaml.
Issues
There are three tables used in producing the central values, each of these data uses different sig.fig, also the legacy data has a higher sig.fig to the current HEP data available.
I am not sure what the procedure is in this case.
Compatibility Checks:
Covariance Matrices:
t0 Matrix: