-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable nf=3 with evolven3fit_new
.
#1754
Conversation
This is ready for review. Some notes:
I think they actually fit well in the
Right now there is no |
@giacomomagni @andreab1997 @niclaurenti once this PR is merged it will be necessary to recompute previous eko due to the Alternatively, this can be fixed in the |
I've opened an issue in eko NNPDF/eko#283 I will remove the hack of |
6166a34
to
d63bda0
Compare
I've reverted the hack. Please @andreab1997 have a look at this when you have time, as far as I am concerned this can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments but it looks good to me
theory["mb"]: thresholds["b"], | ||
theory["mt"]: thresholds["t"], | ||
}, | ||
theory["nf0"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this work, so in principle is fine.
When you call generate_q2grid
with both Q2s given nf0
is ignored. On contrary by default from the cli here we have Q2s to None so you actually want to use nf0
, it's just a bit confusing, but I don't see a quick fix as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the nf0
is acting a bit like a secret parameter to generate the q2grid from the defaults.
I guess another option is not to call generate_q2grid
when there is nothing to generate (just a default being used).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe that's more clean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to point out: nf0
parameter is going to disappear, or better to move. Now that we are propagating evolution points from EKO, everything should be an evolution point (a point on a lane, rather than on the ladder), and also fitting scale will be an evolution point.
So nf0
should be always used, and never None
(despite being always 4, at least for the time being - but remember that is 3 for perturbative charm). You should be allowed to discard the nf
information only at the latest possible time (i.e. when generating the LHAPDF grid file).
nf0
is an EKO extension to the NNPDF theory database, and inferred from the comparison of Q0
with mc * kcThr
, but it would be better to always have it explicit, and infer as little as possible.
@niclaurenti @andreab1997 check that this version is compatible with QED also for 0.13.5 and if so please feel free to merge, there's still the |
@scarlehoff did you apply the changes I was doing in #1758? |
This PR enables the possibility of running
evolven3fit_new
with a fit innf=3
.In order to make it more general now the operator receives a card where every time there is a threshold the Q_threshold is passed for both
nf
andnf+1
in order to avoid the hack of simply repeating one value.The problem at the bottom threshold still remains.
Testing a fit evolved with apfel and eko for theory 200/400, they agree with a relative precision of
1e-3
for all points in x and for Q != mb (for nf=5 the agreement is a bit worse when you are close to mb).I've done the same test for theory 211 (perturbative charm, fit done in nf=3), there we again have a problem at the bottom threshold but as far as I can see the same problem doesn't appear at the charm threshold not sure why.
-> The problem at Q=mb for nf=5 is being investigated. Might be connected to this issue: NNPDF/eko#173
-> The problem at Q=mb for nf=4 is due to eko which at the moment returns an object after evolution which is pdf(q), and pdf(q, nf=4) get's overwritten by pdf(q, nf=5). (same thing happens at nf=3 in theory).
This is still a draft because I would like to:
n3fit
the exportgrid fornf > nf0
.