Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining luminosity combinations #26

Merged
merged 4 commits into from
May 15, 2023
Merged

Fix remaining luminosity combinations #26

merged 4 commits into from
May 15, 2023

Conversation

cschwan
Copy link
Collaborator

@cschwan cschwan commented Dec 22, 2022

It seems I wasn't thorough enough in #25 and missed a few lines. I noticed that while implementing NNPDF/pineappl#199.

I can't guarantee the first commit fixes everything, so I suggest we keep this open until I've tested it extensively.

@scarlehoff
Copy link
Member

Is this ready to be merged? (I forgot about it)

@cschwan
Copy link
Collaborator Author

cschwan commented Jan 31, 2023

I'm no longer sure, I forgot about it too. From my comment it seems it isn't ready yet. I'll have look at it later.

@cschwan
Copy link
Collaborator Author

cschwan commented May 13, 2023

As far as it concerns me, we can now merge this. I fixed all bugs that I discovered using symmetry arguments, but this really is untested, and we should devise a way to test this (in a different Issue though). At the very least we should study the impact of these changes.

@scarlehoff
Copy link
Member

Ok, I'm going to merge this. We probably want to define some bunch of checks in order to make sure that everything works as expected. The problem is that I'm not sure there is any other code with isoscalar target (without hacking) we can compare against?

@scarlehoff scarlehoff merged commit afacfc2 into main May 15, 2023
@scarlehoff scarlehoff deleted the fix-lumis-2 branch May 15, 2023 10:03
@cschwan
Copy link
Collaborator Author

cschwan commented May 15, 2023

A check that we could perform is that we

  1. generate a proton-proton grid,
  2. rewrite the initial state of one proton to the one of an iso-scalar, meaning that we perform the replacements u -> (u + d)/2 and d -> (u + d)/2 (also for the corresponding anti-particles), which will require support in PineAPPL and
  3. compare that against the same calculation with collider = piso.

@cschwan cschwan mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants