-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustify ekore part 2: ad.u.s.{as2,as3} #369
Conversation
Thanks @felixhekhorn |
@felixhekhorn when you have time could you please have a look at Edit: actually the qed stuff is not there. Should I add that as well or for the time being we go for qcd only? |
indeed - let's proceed in parts and first we do QCD only One simple comment up front: please run pre-commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think the
NC=4
case is artificial and we simply don't allow for this hypothetical feature any longer - of course we eventually have to hook the function in on the higher level
crates/ekore/src/anomalous_dimensions/unpolarized/spacelike/as2.rs
Outdated
Show resolved
Hide resolved
crates/ekore/src/anomalous_dimensions/unpolarized/spacelike/as2.rs
Outdated
Show resolved
Hide resolved
…2.rs Co-authored-by: Felix Hekhorn <[email protected]>
(now somehow
8c304b8 should have done this However, there seems to be something fishy: if you rustify and then run |
mm ok. I guess by |
exactly - this will hook the Rust backend into the main eko package + remember to actually compile via |
ok I see. Other question: isn t |
no, since it is a developer dependency - you can do |
okay, so it turns out that it was just a veeery long run for |
yea I think so else every time we commit we have to wait half an hour |
I m trying to run the benchmark |
Ehm, yes this is a feature 🙃 (one that we are trying to partly tackle here) for the first run eko will take a while, because it needs to compile all the numba stuff, which is a lot. Normally it can take up to 15 min if the OME are involved, but actually here it should be quicker, since we're running FFNS and PS: the second run is ~10s for me |
ok after 30 min I ve stopped it and I m trying again setting the two env variables you suggested. Is the singlet sector alright from the benchmark? If so the problem should be something in |
Mmm not sure ... in the singlet sector we match my 0.4% and I'm not sure if that is good enough (LO we match by 0.02%) and we should check with master. I also see that T8 and T15 are kind of okay, but T3 is not - and all should be NS+ ... Of course T3 is small in absolute value, so maybe there is some precision loss somewhere? |
mm i don t know... In the expressions I m doing the following replacements:
does any of this seem wrong? |
anyway I m still stuck on this
not sure what the problem here |
c11f6c4 fixes a stupid typo which was preventing us from passing the benchmark - now we are passing as before. If there are no complaints I will merge this tomorrow. @tgiani c11f6c4 also added an explicit |
@felixhekhorn ah ok good. Yes also after your last commit I still have the same problem on mac |
Continuing from here we can have several parallel parts:
The order of the list is a slight indication of priority. Not every item needs a separate PR although that might help in the review. In case you are not tired yet @tgiani pick your favourite! EDIT: see #383 |
sure, I guess I ll start from 1. What s 2? |
actually quite simple: eko/src/eko/evolution_operator/quad_ker.py Line 107 in 2348778
replace the hardcoded value by reading from _sv_mode_num and put that parameter to a sensible value in the first place
the same holds for item 4 (e.g. they could go in one PR) |
Actually, we should push for the continued rustification before @giacomomagni receives his halo and someone else has to translate all those endless N3LO expression. I will not attempt the full rustification here but still proceed in parts (i.e. this is part 2 (after #189 ) out of X): currently my only goal here is to be ready for QCD N3LO ad. To be specific:
ekore/anomalous_dimensions/unpolarized/space_like/