-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor harmonic cache #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, our hope of a small speed up doesn't seem to be true (LHA bot ran here in 33m and on master on 31m) - nevertheless, I'm still convinced this is a good idea ... (also the impact on eko
is minimal which is good)
(in a future PR we may want to harmonize the arguments of the various functions n,cache,nf
vs. n,nf,cache
- but that is really minor ...)
The exact timing should not be measured on GitHub Actions machines: they are not uniform, and most likely virtual, so you never know the exact performances on comparable hardware. However, the message is that the order of magnitude is unchanged. |
Are you sure this do not depends also on other factors? I checked that some older benchmark took longer other were quicker... Most likely we haven't gained much apart in code cleaning and #143
True |
Since we have introduced a lot of new elements we will need to restructure the harmonic cache.
Reimplementation of #202