Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor harmonic cache #253

Merged
merged 25 commits into from
May 3, 2023
Merged

Refactor harmonic cache #253

merged 25 commits into from
May 3, 2023

Conversation

giacomomagni
Copy link
Collaborator

@giacomomagni giacomomagni commented Apr 28, 2023

Since we have introduced a lot of new elements we will need to restructure the harmonic cache.

Reimplementation of #202

  • Add the cache, tests and relative cleaning
  • Rewrite all the anomalous dimension modules and relative tests
  • Rewrite all the matching conditions modules and relative tests
  • Benchmark and check for any numba error

@giacomomagni giacomomagni added the refactor Refactor code label Apr 28, 2023
@giacomomagni giacomomagni self-assigned this Apr 28, 2023
@giacomomagni giacomomagni marked this pull request as draft April 28, 2023 15:47
@felixhekhorn felixhekhorn linked an issue Apr 28, 2023 that may be closed by this pull request
@giacomomagni giacomomagni marked this pull request as ready for review May 2, 2023 08:40
Copy link
Contributor

@felixhekhorn felixhekhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, our hope of a small speed up doesn't seem to be true (LHA bot ran here in 33m and on master on 31m) - nevertheless, I'm still convinced this is a good idea ... (also the impact on eko is minimal which is good)

(in a future PR we may want to harmonize the arguments of the various functions n,cache,nf vs. n,nf,cache - but that is really minor ...)

@alecandido
Copy link
Member

(LHA bot ran here in 33m and on master on 31m)

The exact timing should not be measured on GitHub Actions machines: they are not uniform, and most likely virtual, so you never know the exact performances on comparable hardware.

However, the message is that the order of magnitude is unchanged.

@giacomomagni
Copy link
Collaborator Author

Unfortunately, our hope of a small speed up doesn't seem to be true (LHA bot ran here in 33m and on master on 31m) - nevertheless, I'm still convinced this is a good idea ... (also the impact on eko is minimal which is good)

Are you sure this do not depends also on other factors? I checked that some older benchmark took longer other were quicker... Most likely we haven't gained much apart in code cleaning and #143

(in a future PR we may want to harmonize the arguments of the various functions n,cache,nf vs. n,nf,cache - but that is really minor ...)

True

@giacomomagni giacomomagni merged commit 1ae0d03 into master May 3, 2023
@giacomomagni giacomomagni deleted the harmonic_sum_cache_2 branch May 3, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing deprecated list of list in harmonic cache
4 participants