Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create recipes #217

Closed
wants to merge 2 commits into from
Closed

Create recipes #217

wants to merge 2 commits into from

Conversation

alecandido
Copy link
Member

@alecandido alecandido commented Feb 23, 2023

  • create recipe files in a new EKO
    • new EKO: empty recipes/, parts/, and operators/ folders
  • double check the information in the recipe to be sufficient for computation

@alecandido alecandido marked this pull request as draft February 23, 2023 19:29
@felixhekhorn felixhekhorn added output Output format and management refactor Refactor code labels Feb 24, 2023
@alecandido alecandido mentioned this pull request Feb 24, 2023
@alecandido
Copy link
Member Author

In commit 85975ad a further breaking change is introduced.

There is no hurry to merge this PR, for as long as there is not the full alternative runner. In any case, even the full alternative runner will deprecate, but not immediately drop, the old one, so this will still be compatible.

Since I had to play with these quantities to use them in the new runner as well, I decided to start improving (or just factorizing) a bit the content of the current one.
In light of #205 I tried to improve the existing classes.

However, if the changes are welcome, I can keep going fixing the tests/benchmarks/docs (in principle should simplify the current definitions, also clarifying the role of linear and squared scales).
Otherwise, it is sufficient to drop that commit. @felixhekhorn let me know.

@alecandido alecandido mentioned this pull request Feb 28, 2023
6 tasks
alecandido added a commit that referenced this pull request Mar 10, 2023
@alecandido alecandido changed the base branch from master to rearrange-runcards-metadata March 12, 2023 10:54
@alecandido
Copy link
Member Author

This is now rebased on top of #220, and I will restart work on this one as soon as #220 will be close to final.

alecandido added a commit that referenced this pull request Mar 22, 2023
@alecandido alecandido force-pushed the rearrange-runcards-metadata branch from b86b48f to 3175185 Compare March 22, 2023 06:30
alecandido added a commit that referenced this pull request Mar 29, 2023
@alecandido alecandido force-pushed the rearrange-runcards-metadata branch from 1166680 to 7c10b05 Compare March 29, 2023 12:40
alecandido added a commit that referenced this pull request Mar 30, 2023
@alecandido alecandido force-pushed the rearrange-runcards-metadata branch from e8d1f4f to 43bbad3 Compare March 30, 2023 18:32
alecandido added a commit that referenced this pull request Mar 31, 2023
@alecandido alecandido force-pushed the rearrange-runcards-metadata branch from c9e5ff6 to e3ec8ed Compare March 31, 2023 16:14
Base automatically changed from rearrange-runcards-metadata to master March 31, 2023 16:41
With the not yet implemented one
@alecandido alecandido mentioned this pull request Apr 4, 2023
10 tasks
@alecandido
Copy link
Member Author

By now, this PR has a wrong name (and the board is even messy). The goal is to have a minimal jets runner, otherwise it has hard to test and compare against the previous one.

I opened #242 to replace this.

@alecandido alecandido closed this Apr 4, 2023
@giacomomagni giacomomagni deleted the create-recipes branch May 9, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
output Output format and management refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants