Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache harmonics sums for the as2 anomalous dimensions #179

Closed
wants to merge 17 commits into from

Conversation

niclaurenti
Copy link
Contributor

Dear @felixhekhorn @alecandido @giacomomagni I'm opening this PR since in the anomalous dimensions at order as2 there are some harmonics sums that are used also in the QED sector. Then, as @felixhekhorn was suggesting we can use the ones that were cached in the computation of the QED anomalous dimensions. I didn't want to include these changes in the QED PR since it is already big enough.

@niclaurenti niclaurenti added the refactor Refactor code label Dec 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Merging #179 (63d800a) into feature/qed-solution (c825451) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           feature/qed-solution     #179      +/-   ##
========================================================
- Coverage                 99.96%   99.96%   -0.01%     
========================================================
  Files                       100      100              
  Lines                      5224     5194      -30     
========================================================
- Hits                       5222     5192      -30     
  Misses                        2        2              
Flag Coverage Δ
isobench ?
unittests 99.96% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/eko/anomalous_dimensions/__init__.py 100.00% <100.00%> (ø)
src/eko/anomalous_dimensions/aem2.py 100.00% <100.00%> (ø)
src/eko/anomalous_dimensions/as1aem1.py 100.00% <100.00%> (ø)
src/eko/anomalous_dimensions/as2.py 100.00% <100.00%> (ø)
src/eko/harmonics/__init__.py 100.00% <100.00%> (ø)
src/eko/runcards.py 100.00% <0.00%> (ø)
src/eko/constants.py 100.00% <0.00%> (ø)
src/eko/output/struct.py 100.00% <0.00%> (ø)
src/eko/basis_rotation.py 100.00% <0.00%> (ø)
src/eko/harmonics/constants.py 100.00% <0.00%> (ø)

@niclaurenti niclaurenti changed the title Feature/cache harm sums Cache harmonics sums for the as2 anomalous dimensions Dec 9, 2022
@felixhekhorn
Copy link
Contributor

why not upgrade the existing compute_cache? it computes already a list of e.g. weight 3 sums? and as said we want to have the minimal number possible ...

@giacomomagni
Copy link
Collaborator

why not upgrade the existing compute_cache? it computes already a list of e.g. weight 3 sums? and as said we want to have the minimal number possible ...

To use that you would need to rotate some harmonics, for instance get rid of S[m, (n-1)/2] in favor or S[-m,n], but I'd definitely do that. Note that also g3 only enters in the anomalous dimensions through S[-2,1,n] and using the series definition you can simplify g3(n+2)

((1, 1), 10200, 10200, "iterate-exact", 0.123, 1.0),
((1, 1), 10200, 10204, "iterate-exact", 0.123, 0.0),
]
for p in params:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe better for order,mode0,mode1,bla,bla in params?

@felixhekhorn felixhekhorn mentioned this pull request Jan 26, 2023
1 task
@niclaurenti
Copy link
Contributor Author

@felixhekhorn @alecandido @giacomomagni Should I close this PR given that this will be implemented in #202 ?

@felixhekhorn
Copy link
Contributor

You can close it now if you're not actively using this branch or later when #202 is fully in place ...

@niclaurenti
Copy link
Contributor Author

You can close it now if you're not actively using this branch or later when #202 is fully in place ...

Ok let's close it when #202 is completed

Base automatically changed from feature/qed-solution to master March 9, 2023 16:24
@alecandido
Copy link
Member

alecandido commented Mar 31, 2023

Since some time passed, even if #202 is not yet done at this point we know nothing else will happen here. Thus, I'm closing this.

@alecandido alecandido closed this Mar 31, 2023
@giacomomagni giacomomagni deleted the feature/cache-harm-sums branch April 28, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants