Feat/1571 forgotten username display username #6450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssrome
changed the base branch from
main
to
feature-branch/forgotten-username
kapppa-joe
reviewed
Dec 19, 2024
|
|
||
| ngOnInit(): void { | ||
| this.getUsernameFound(); | ||
| this.isUsernameFound = this.username !== null ? true : false; |
There was a problem hiding this comment.
probably we could simplify it as
Suggested change
| this.isUsernameFound = this.username !== null ? true : false; | |
| this.isUsernameFound = this.username !== null |
Or, at the html template, we could set the if condition as username !== null
kapppa-joe
reviewed
Dec 19, 2024
| class="govuk-panel govuk-panel--gray govuk-util__align-left govuk-!-margin-top-1 govuk-!-padding-top-1 govuk-!-padding-bottom-5 govuk-!-padding-left-2 govuk-!-padding-right-0 panel" | ||
| data-testid="panel" | ||
| > | ||
| <h1 class="govuk-!-font-size-36 govuk-!-margin-top-4 govuk-!-margin-bottom-3"> |
There was a problem hiding this comment.
We could use govuk-heading-l instead of govuk-!-font-size-36 here. Both are same font size, but in most case we use the heading classes for h1
There was a problem hiding this comment.
Changed to use the gov heading class
kapppa-joe
approved these changes
Dec 19, 2024
kapppa-joe
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work done
Tests
Does this PR include tests for the changes introduced?