Code

Feature branch/quals certificate#6420

Code

Merged

duncanc19 merged 122 commits intomainNMDSdevopsServiceAdm/SopraSteria-SFC:mainfrom featureBranch/qualsCertificateNMDSdevopsServiceAdm/SopraSteria-SFC:featureBranch/qualsCertificateCopy head branch name to clipboardNov 22, 2024

+5,257-1,455

Commits

Commits on Oct 8, 2024

• merged training certificates and quals accordions

  Jonopono123

  committed
  19adc57

• (WIP) temp store current changes

  kapppa-joe

  committed
  d31e029

Commits on Oct 9, 2024

• add certificate related html elements to add-edit-qualification component

  kapppa-joe

  committed
  b0743d7

• amend css to allow certificate table display in full width

  kapppa-joe

  committed
  1dba8be

• add validation for cert upload

  kapppa-joe

  committed
  0a56efc

• add more unit tests

  kapppa-joe

  committed
  8cc4044

• added new qualificationCertificates table migration, moved training certificate upload functionality into new generic worker certificate service

  Jonopono123

  committed
  1aa727d

Commits on Oct 10, 2024

• added new quals cert service

  Jonopono123

  committed
  d374334

Commits on Oct 11, 2024

• start adding certificate service to frontend

  kapppa-joe

  committed
  075a78a

• migrate certificate related method from trainingService to certficateService

  kapppa-joe

  committed
  c332a44

• migrate references for certificate related methods to CertificateService

  kapppa-joe

  committed
  e0bc99d

• remove commented out / duplicated code in add-edit-training component

  kapppa-joe

  committed
  742ac78

• minor change in typings

  kapppa-joe

  committed
  228beca

• amend method name

  kapppa-joe

  committed
  dbfa522

• move tests about upload button to the new shared component (select-upload-certificate)

  kapppa-joe

  committed
  ee35b6e

• amend one unit test

  kapppa-joe

  committed
  cc50c57

• add logic to prevent submit button being triggered more than once

  kapppa-joe

  committed
  f078f24

Commits on Oct 14, 2024

• clear error message on remove button clicked, css adjustment

  kapppa-joe

  committed
  1ffc9d9

• adjust css styling

  kapppa-joe

  committed
  5057a9d

• address PR comments

  kapppa-joe

  committed
  dc76c02

• Merge pull request #6385 from NMDSdevopsServiceAdm/feat/1525-add-a-new-quals-with-cert

  Show description for 5834ffe
  kapppa-joe

  authored
  5834ffe

Commits on Oct 15, 2024

• Refactored tests for new workerCertificateService

  Jonopono123

  committed
  ba1f91d

Commits on Oct 16, 2024

• added test suite around certificate endpoints

  Jonopono123

  committed
  f3ed00b

• refactored tests

  Jonopono123

  committed
  d3668bf

• refactored training deletion tests

  Jonopono123

  committed
  6a5389a

• further refactoring on tests

  Jonopono123

  committed
  4a1b036

• removed unneeded imports

  Jonopono123

  committed
  554c32c

Commits on Oct 17, 2024

• fixed upload

  Jonopono123

  committed
  438ea78

• resolved download payload issue

  Jonopono123

  committed
  80b0180

• fixed and refactored failing tests

  Jonopono123

  committed
  699d3da

• Update backend/server/routes/establishments/qualification/index.js

  Show description for 32dd57f
  

  Jonopono123

  and

  kapppa-joe

  authored
  32dd57f

• Remove unneeded log

  Show description for 390b2d7
  

  Jonopono123

  and

  kapppa-joe

  authored
  390b2d7

• Rename param

  Show description for 03c6b79
  

  Jonopono123

  and

  kapppa-joe

  authored
  03c6b79

• removed unneeded param formatting

  Jonopono123

  committed
  5344955

• Merge branch 'feat/1526-qualsCertsBackend' of https://github.com/NMDSdevopsServiceAdm/SopraSteria-SFC into feat/1526-qualsCertsBackend

  Show description for d34cc24
  Jonopono123

  committed
  d34cc24

• renamed endpoint functions to avoid confusion

  Jonopono123

  committed
  3ac5fd0

Commits on Oct 18, 2024

• fixed mismatched args/params

  Jonopono123

  committed
  ce1bbcb

• updated args in deleteCertificates call

  Jonopono123

  committed
  6b1d64a

• Merge pull request #6387 from NMDSdevopsServiceAdm/feat/1526-qualsCertsBackend

  Show description for 62f413f
  Jonopono123

  authored
  62f413f

• add test for summary page

  kapppa-joe

  committed
  ff4a09e

• (WIP) implementing certificate cell for new-qualifications component

  kapppa-joe

  committed
  7af8c74

• amend summary page and table component to use unified event type for certificates upload and download

  kapppa-joe

  committed
  62b3bb1

• implement event emitters at new-qualifications component

  kapppa-joe

  committed
  0facaab

• refactor tests setup at new-training-and-qualifications-record

  kapppa-joe

  committed
  ffaafe1

• start adding unit tests for qualification certificate methods at summary page

  kapppa-joe

  committed
  8ea8587

• add unit tests for qualification cert error message in summary page

  kapppa-joe

  committed
  276f45f

• refactor the way that new-training component displays error message

  kapppa-joe

  committed
  8e50c6a

• tidy up

  kapppa-joe

  committed
  617d6f1

• remove commented out mock data for testing frontend

  kapppa-joe

  committed
  33d68f3

• unify the format of request and response body for cert endpoints

  kapppa-joe

  committed
  9e1d731

• Merge pull request #6386 from NMDSdevopsServiceAdm/feat/1529-qualification-summary-page

  Show description for 0d83289
  kapppa-joe

  authored
  0d83289

Commits on Oct 22, 2024

• add qualification certificates when fetching qualification at backend

  kapppa-joe

  committed
  a747413

• amend link text for downloading pdf, fix a bug that cause pdf to not render correctly

  kapppa-joe

  committed
  00726f5

• add download all certificates link

  kapppa-joe

  committed
  ac14068

• install @zip.js, add method to handle zipping file at frontend

  kapppa-joe

  committed
  4c8b326

Commits on Oct 23, 2024

• Merge pull request #6392 from NMDSdevopsServiceAdm/feat/1545-update-GET-endpoints-to-include-quals-certs

  Show description for 6be0091
  kapppa-joe

  authored
  6be0091

• fixed failing tests for certs

  Jonopono123

  committed
  60ca281

• added tests to Qualification restore functionality

  Jonopono123

  committed
  34b3a56

• added test case to cover failed to load qual scenario

  Jonopono123

  committed
  123dae7

• Merge branch 'featureBranch/qualsCertificate' into feat/1527-delete-certificate-on-quals-deletion

  Jonopono123

  committed
  7acfe08

• add type declaration and unit test to file util

  kapppa-joe

  committed
  a5b232d

• added missing "await"

  Jonopono123

  committed
  75ed1b0

• add unit tests for downloadAllCertificatesAsBlobs, try test downloading zip from browser

  kapppa-joe

  committed
  58f0ca2

Commits on Oct 24, 2024

• add unit tests for download all certificates

  kapppa-joe

  committed
  faa5cc4

• add unit tests, rename method

  kapppa-joe

  committed
  9718d95

• add logic to avoid download all button being triggered again while downloading

  kapppa-joe

  committed
  bf8b846

Commits on Oct 25, 2024

• add ngif to not display download all if worker has no certificates at all

  kapppa-joe

  committed
  9e74707

• fix typo

  kapppa-joe

  committed
  cf8260b

• Merge pull request #6394 from NMDSdevopsServiceAdm/feat/1527-delete-certificate-on-quals-deletion

  Show description for 4bff689
  Jonopono123

  authored
  4bff689

• capitalise the name of zip file and inner folders

  kapppa-joe

  committed
  fccf840

• rearrange method orders, remove console log

  kapppa-joe

  committed
  79139ae

• tidy up

  kapppa-joe

  committed
  e6115f9

• fixed qualifications models tests not running

  Jonopono123

  committed
  7615422

• Merge pull request #6397 from NMDSdevopsServiceAdm/fix/qualifications-tests

  Show description for 65dc954
  Jonopono123

  authored
  65dc954

Commits on Oct 28, 2024

• Merge pull request #6396 from NMDSdevopsServiceAdm/feat/1528-download-all-training-and-quals-certificates

  Show description for 894de6f
  kapppa-joe

  authored
  894de6f

Commits on Oct 31, 2024

• merged featureBranch/training-certificates into featureBranch/qualsCertificate

  Jonopono123

  committed
  ca8d042

Commits on Nov 1, 2024

• fixed failing tests resulting from merge

  Jonopono123

  committed
  b09b6ae

• resolved conflicts from pull

  Jonopono123

  committed
  8253d9a

• Merge latest changes from training certificates into branch

  duncanc19

  committed
  b79564a

• Add canEditWorker check for displaying qualification certificate links on training and quals summary page

  duncanc19

  committed
  62f10a0

• Update test names to say qualification instead of training

  duncanc19

  committed
  96d37b0

• refactoring delete all certificates functionality

  Jonopono123

  committed
  29aea0e

• refactored functionality for deleting all training certificates

  Jonopono123

  committed
  70326f0

Commits on Nov 4, 2024

• Merge pull request #6402 from NMDSdevopsServiceAdm/fix/hide-qualification-certificate-links-for-read-only-users

  Show description for 3905a36
  duncanc19

  authored
  3905a36

• add a helper class to process bulk upload qualifications

  kapppa-joe

  committed
  fb3294d

• bugfix for DELETE qualification endpoint not working when qualification has no certs

  kapppa-joe

  committed
  0631787

• bugfix for DELETE training endpoint as well

  kapppa-joe

  committed
  f979a7a

• amend backend workerCertificateService so that file key retrieval works even if worker changed their workplace

  kapppa-joe

  committed
  fa69c9a

• add unit tests to verify change

  kapppa-joe

  committed
  43053f7

• implementing deleteQualification

  kapppa-joe

  committed
  1c66038

• add test for deleteQualification at bulk upload

  kapppa-joe

  committed
  945631b

• ensure new logic only triggered in bulk upload process

  kapppa-joe

  committed
  c39ee3f

• tidy up

  kapppa-joe

  committed
  daa3547

• minor fix

  kapppa-joe

  committed
  d6ead32

• remove console logs

  kapppa-joe

  committed
  1e40b69

• amend wording for clarity

  kapppa-joe

  committed
  91a91bf

• address PR comment (about bulkUploaded boolean at helper class)

  kapppa-joe

  committed
  2e9fb06

• add a missing await

  kapppa-joe

  committed
  5c7ce9d

• Refactored training cert deletion

  Jonopono123

  committed
  d8ffe68

• added bulk quals cert deletion functionality

  Jonopono123

  committed
  5aa67e9

• remove redundant method verifyParentRecordExists / findParentRecord

  kapppa-joe

  committed
  72e9239

• added delete all quals certs tests to workerCertificateService

  Jonopono123

  committed
  5200858

Commits on Nov 5, 2024

• refactor

  kapppa-joe

  committed
  1fd06f7

• added transaction to deleteCertificate function on qualificationCertificates model

  Jonopono123

  committed
  afa2a9a

• PR changes and some additional test cases

  Jonopono123

  committed
  abcb721

• Removed BU Quals cert deletion and refactored error handling

  Jonopono123

  committed
  f7211de

• changed HttpErrors on training class back to regular Errors

  Jonopono123

  committed
  3f817dd

Commits on Nov 6, 2024

• Merge pull request #6404 from NMDSdevopsServiceAdm/feat/1544-delete-qualification-certificate-on-workplace-deletion

  Show description for e90ae32
  Jonopono123

  authored
  e90ae32

• Merge branch 'featureBranch/qualsCertificate' into feat/1549-bulk-upload-retain-existing-qualifications

  kapppa-joe

  committed
  a847fe9

• Merge pull request #6403 from NMDSdevopsServiceAdm/feat/1549-bulk-upload-retain-existing-qualifications

  Show description for 2e52321
  kapppa-joe

  authored
  2e52321

Commits on Nov 15, 2024

• Merge branch 'main' into featureBranch/qualsCertificate

  kapppa-joe

  committed
  df6660e

Commits on Nov 19, 2024

• Create shared asc-training-and-quals-table class to match styling for training and qualification tables

  duncanc19

  committed
  e512ee4

• swapped the priority of the error messages for cert uploads

  Jonopono123

  committed
  65eb253

• Merge pull request #6418 from NMDSdevopsServiceAdm/fix/qualification-table-row-height-when-upload-button

  Show description for 98624ad
  duncanc19

  authored
  98624ad

Commits on Nov 20, 2024

• Merge pull request #6419 from NMDSdevopsServiceAdm/fix/upload-cert-error-message-priority

  Show description for fa8e46c
  Jonopono123

  authored
  fa8e46c

• Update deleteTrainingRecord endpoint to check for certificates correctly

  duncanc19

  committed
  077a779

• Refactor to remove if else nesting

  duncanc19

  committed
  e95d9f7

• Merge pull request #6421 from NMDSdevopsServiceAdm/fix/delete-certificates-when-deleting-training-record

  Show description for 6525781
  duncanc19

  authored
  6525781

Commits on Nov 21, 2024

• add CHGSUB to the if branch condition to call BulkUploadQualificationHelper

  kapppa-joe

  committed
  4298331

• Merge pull request #6424 from NMDSdevopsServiceAdm/fix/add-change-sub-to-bulk-upload-quals-helper

  Show description for 92ac039
  duncanc19

  authored
  92ac039

Commits on Nov 22, 2024

• Send default Internal server error message when unexpected errors occur in the WorkerCertificate service

  duncanc19

  committed
  24775f4

• Merge pull request #6425 from NMDSdevopsServiceAdm/fix/only-return-expected-error-messages-for-certificates

  Show description for 7916e3a
  duncanc19

  authored
  7916e3a