Increase efficiency of check for training certificates on Bulk Upload page #6410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… certs in bulk upload
…aining to determine if training cert exists for workplace or sub
duncanc19
force-pushed
the
fix/make-bu-check-for-training-certs-more-efficient
branch
from
6328857 to
d6a5383
Compare
ssrome
approved these changes
Nov 14, 2024
ssrome
approved these changes
Nov 14, 2024
duncanc19
deleted the
fix/make-bu-check-for-training-certs-more-efficient
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
With the introduction of training certificates, a check was added to the bulk upload page for training certificates for the workplace or any subs, in order to display a warning that the certificates will be deleted if they upload the training file. The functionality worked as expected, but for one particularly large parent workplace, the page was failing to load and the server continually returned a 503 response. This PR attempts to improve the efficiency of the endpoint.
Work done
Tests
Does this PR include tests for the changes introduced?