Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/1501 styling #6362

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Bug/1501 styling #6362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
828df42
resolved layout issue on create username page
Jonopono123 Sep 9, 2024
8fcd41d
resolved styling issue on workplace table when error messages are dis…
Jonopono123 Sep 18, 2024
a65fccc
Merge branch 'main' into bug/1501-styling
Jonopono123 Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...end/src/app/features/activate-user-account/create-username/create-username.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ <h1 class="govuk-fieldset__heading">Create your username and password</h1>

<div class="govuk-form-group" [class.govuk-form-group--error]="submitted && getUsername.errors">
<label class="govuk-label" for="username"> Username </label>
<span id="username-hint" class="govuk-hint"
>You'll use this to sign in, so it needs to be unique to you.</span
<div id="username-hint" class="govuk-hint"
>You'll use this to sign in, so it needs to be unique to you.</div
>
<span *ngIf="submitted && getUsername.errors" id="username-error" class="govuk-error-message">
<span class="govuk-visually-hidden">Error:</span>
Expand All @@ -36,10 +36,10 @@ <h1 class="govuk-fieldset__heading">Create your username and password</h1>
<div [formGroupName]="'passwordGroup'">
<div class="govuk-form-group" [class.govuk-form-group--error]="submitted && getPassword.errors">
<label class="govuk-label" for="createPasswordInput"> Password </label>
<span id="createPasswordInput-hint" class="govuk-hint">
<div id="createPasswordInput-hint" class="govuk-hint">
Must be at least 8 characters long and have uppercase letters, lowercase letters, numbers and special
characters like !, £.
</span>
</div>
<span
*ngIf="submitted && getPassword.errors"
id="passwordGroup-createPasswordInput-error"
Expand Down Expand Up @@ -71,6 +71,7 @@ <h1 class="govuk-fieldset__heading">Create your username and password</h1>

<div class="govuk-form-group" [class.govuk-form-group--error]="submitted && getConfirmPassword.errors">
<label class="govuk-label" for="confirmPasswordInput"> Confirm password </label>

<span
*ngIf="submitted && getConfirmPassword.errors"
id="passwordGroup-confirmPasswordInput-error"
Expand Down
3 changes: 2 additions & 1 deletion frontend/src/assets/scss/components/_summary-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,13 @@
}
}

.govuk-summary-list__row--no-bottom-border {
.govuk-summary-list__row.govuk-summary-list__row--no-bottom-border {
.govuk-summary-list__key,
.govuk-summary-list__value,
.govuk-summary-list__actions {
border-bottom: none;
}
border-bottom: none;
}

.govuk-summary-list__row--no-bottom-padding {
Expand Down
Loading