Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1448 cqc banner for subs #6300

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

duncanc19
Copy link
Collaborator

Issue

The CQC banner (to warn users that there is a mismatch between their data on our service and their CQC data) was not displaying when viewing subs from a parent account. This was due to it not having been implemented for subs. This PR changes the implementation of using a service to store whether to display the banner which was getting cleared when viewing a sub, to use a resolver which is used on both the parent/stand alone and sub dashboards.

Work done

  • Created resolver which gets data for whether to show the CQC banner, and updated all home/workplace tab pages to use it
  • Removed CQC banner code from establishment service
  • Corrected localhost file path in gitignore so we can use it to store variables we don't want to push to Github

Tests

Does this PR include tests for the changes introduced?

  • Yes
  • No, I found it difficult to test
  • No, they are not required for this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants