add a fullstop, remove fdescribe

NMDSdevopsServiceAdm · Dec 16, 2024 · fa2257b · fa2257b
1 parent 5de7a2d
commit fa2257b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/frontend/src/app/core/services/find-username.service.spec.ts b/frontend/src/app/core/services/find-username.service.spec.ts
@@ -5,7 +5,7 @@ import { TestBed } from '@angular/core/testing';
 
 import { FindUsernameService } from './find-username.service';
 
-fdescribe('FindUsernameService', () => {
+describe('FindUsernameService', () => {
   let service: FindUsernameService;
   let http: HttpTestingController;
 

diff --git a/...your-username-or-password/forgot-your-username/find-username/find-username.component.html b/...your-username-or-password/forgot-your-username/find-username/find-username.component.html
@@ -4,7 +4,7 @@
     <div class="govuk-grid-column-two-thirds-from-desktop">
       <div class="asc-security-question__container">
         <h3 class="govuk-heading-m">Your security question</h3>
-        <p>You chose this question when you created your account</p>
+        <p>You chose this question when you created your account.</p>
         <h4 class="govuk-heading-s">Question</h4>
         <div id="securityQuestion" class="asc-security-question" #securityQuestionEl tabindex="-1">
           {{ securityQuestion }}

diff --git a/...got-your-username-or-password/forgot-your-username/forgot-your-username.component.spec.ts b/...got-your-username-or-password/forgot-your-username/forgot-your-username.component.spec.ts
@@ -15,7 +15,7 @@ import { FindAccountComponent } from './find-account/find-account.component';
 import { FindUsernameComponent } from './find-username/find-username.component';
 import { ForgotYourUsernameComponent } from './forgot-your-username.component';
 
-fdescribe('ForgotYourUsernameComponent', () => {
+describe('ForgotYourUsernameComponent', () => {
   const setup = async () => {
     const setupTools = await render(ForgotYourUsernameComponent, {
       imports: [HttpClientTestingModule, FormsModule, ReactiveFormsModule, RouterTestingModule, SharedModule],
@@ -167,7 +167,7 @@ fdescribe('ForgotYourUsernameComponent', () => {
     });
   });
 
-  fdescribe('Find username', () => {
+  describe('Find username', () => {
     const setupAndProceedToFindUsername = async () => {
       const setuptools = await setup();
 
@@ -189,7 +189,7 @@ fdescribe('ForgotYourUsernameComponent', () => {
         const { getByText } = await setupAndProceedToFindUsername();
 
         expect(getByText('Your security question')).toBeTruthy();
-        expect(getByText('You chose this question when you created your account')).toBeTruthy();
+        expect(getByText('You chose this question when you created your account.')).toBeTruthy();
         expect(getByText('Question')).toBeTruthy();
         expect(getByText(mockTestUser.securityQuestion)).toBeTruthy();
       });
@@ -274,7 +274,7 @@ fdescribe('ForgotYourUsernameComponent', () => {
         expect(findUsernameService.usernameFound).toEqual(null);
       });
 
-      fit('should show a different error message when only 1 chance remain', async () => {
+      it('should show a different error message when only 1 chance remain', async () => {
         const { fixture, getByRole, getByText, findUsernameService } = await setupAndProceedToFindUsername();
         spyOn(findUsernameService, 'findUsername').and.returnValue(of({ answerCorrect: false, remainingAttempts: 1 }));