Merge pull request #6418 from NMDSdevopsServiceAdm/fix/qualification-…

…table-row-height-when-upload-button Fix: Qualification table row height when upload button
NMDSdevopsServiceAdm · Nov 19, 2024 · 98624ad · 98624ad
2 parents df6660e + e512ee4
commit 98624ad
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/...s/new-training-qualifications-record/new-qualifications/new-qualifications.component.html b/...s/new-training-qualifications-record/new-qualifications/new-qualifications.component.html
@@ -7,7 +7,7 @@ <h1 class="govuk-heading-l govuk-!-font-size-27">Qualifications</h1>
         <span aria-live="polite">
           <app-validation-error-message *ngIf="certificateErrors?.[qualificationGroup.group]" [errorMessage]="certificateErrors[qualificationGroup.group]" />
         </span>
-        <table class="govuk-table">
+        <table class="govuk-table asc-training-and-quals-table">
           <caption class="govuk-visually-hidden">
             {{
               qualificationGroup.group

diff --git a/...ualifications/new-training-qualifications-record/new-training/new-training.component.html b/...ualifications/new-training-qualifications-record/new-training/new-training.component.html
@@ -10,7 +10,7 @@ <h1 class="govuk-heading-l govuk-!-font-size-27">{{ trainingType }}</h1>
         <span aria-live="polite">
           <app-validation-error-message *ngIf="certificateErrors?.[trainingCategory.category]" [errorMessage]="certificateErrors?.[trainingCategory.category]" />
         </span>
-        <table class="govuk-table govuk-!-margin-bottom-7">
+        <table class="govuk-table asc-training-and-quals-table govuk-!-margin-bottom-7">
           <caption
             class="govuk-visually-hidden"
           >

diff --git a/...ualifications/new-training-qualifications-record/new-training/new-training.component.scss b/...ualifications/new-training-qualifications-record/new-training/new-training.component.scss
diff --git a/...-qualifications/new-training-qualifications-record/new-training/new-training.component.ts b/...-qualifications/new-training-qualifications-record/new-training/new-training.component.ts
@@ -11,7 +11,6 @@ import { TrainingStatusService } from '@core/services/trainingStatus.service';
 @Component({
   selector: 'app-new-training',
   templateUrl: './new-training.component.html',
-  styleUrls: ['./new-training.component.scss'],
 })
 export class NewTrainingComponent implements OnChanges {
   @Input() public trainingCategories: TrainingRecordCategory[];

diff --git a/frontend/src/assets/scss/components/_tables.scss b/frontend/src/assets/scss/components/_tables.scss
@@ -96,3 +96,10 @@ $error_row_padding: $govuk-gutter-half;
 .govuk-table-custom-width {
   width: 20% !important;
 }
+
+.asc-training-and-quals-table {
+  td.govuk-table__cell:has(button) {
+    padding-top: 6px;
+    padding-bottom: 6px;
+  }
+}