Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated CONTRIBUTING.rst #37

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Updated CONTRIBUTING.rst #37

merged 1 commit into from
Dec 7, 2018

Conversation

gopavasanth
Copy link
Contributor

Fixed few Typos

All Submissions:

  • Have you followed the guidelines in our Contributing document?

New Feature Submissions:

  1. Does your submission pass build tests locally?
  2. Have you indented your code locally prior to submission?

Changes to Core Features:

  • Have you successfully ran tests with your changes locally?

@monsij
Copy link
Member

monsij commented Dec 7, 2018

Hope that you have followed the contribution guidelines. Please don't make a request anywhere to get a review. One of the maintainers will get back to it within a day or so. 😃

(Powered by GitMate.io)

@gopavasanth
Copy link
Contributor Author

By seeing the CONTRIBUTING.rst I found a couple of typos, I Checked with Grammarly I found this requires a sort of updates, So I made this PR to fix those common minor mistakes.

@gopavasanth
Copy link
Contributor Author

#38

monsij
monsij approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@monsij monsij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@monsij
Copy link
Member

monsij commented Dec 7, 2018

"@gitmate-bot rebase"

@monsij
Copy link
Member

monsij commented Dec 7, 2018

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@monsij
Copy link
Member

monsij commented Dec 7, 2018

Automated rebase with GitMate.io was successful! 🎉

@monsij
Copy link
Member

monsij commented Dec 7, 2018

ack 30d0877

@monsij monsij merged commit f438670 into NIT-DGPortal:master Dec 7, 2018
gutsytechster pushed a commit to gutsytechster/StudentPortal that referenced this pull request Dec 17, 2018
@gopavasanth @gutsytechster
Updated CONTRIBUTING.rst (NIT-DGPortal#37)
472ff1f 
Correct typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsij monsij monsij approved these changes

Assignees

@gopavasanth gopavasanth

Labels
size/XS status/approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gopavasanth @monsij