Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic sync for contributors page #33

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Dynamic sync for contributors page #33

merged 1 commit into from
Dec 7, 2018

Conversation

harry-hov
Copy link
Contributor

@harry-hov harry-hov commented Dec 7, 2018 •
edited
Loading

What i did ?

1. Contributors page is now in sync with Github and show realtime data(Followers, Following, etc).

screenshot 55

2. No more need to store profile pics locally. Now we can save some space.

3. Added few animations.

4. Now its simple to add Contributors in "Contributors page". Type one line and you are done.

<div class="github-card" data-github="git_username" data-theme="medium"></div>

@monsij
Copy link
Member

monsij commented Dec 7, 2018

Hope that you have followed the contribution guidelines :-)

(Powered by GitMate.io)

@harry-hov
Copy link
Contributor Author

harry-hov commented Dec 7, 2018 •
edited
Loading

All Submissions:

  • Have you followed the guidelines in our Contributing document?

New Feature Submissions:

  1. Does your submission pass build tests locally?
  2. Have you indented your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

@harry-hov
Copy link
Contributor Author

PR regarding #25 #2 #32

@monsij
Copy link
Member

monsij commented Dec 7, 2018

@harry-hov Can you add the info about the number of commits the user has made .. And the no.of reviews made.Remove the number of repos and following and replace them with the above.

@monsij
Copy link
Member

monsij commented Dec 7, 2018

Also let us know if the files under __pycache__ is required to be commited or they are just cache files

@harry-hov
Copy link
Contributor Author

@harry-hov Can you add the info about the number of commits the user has made .. And the no.of reviews made.Remove the number of repos and following and replace them with the above.

It cant do this without Github API keys.

@monsij
Copy link
Member

monsij commented Dec 7, 2018 •
edited
Loading

Ok so should we go for it ? It would be better i guess

@harry-hov
Copy link
Contributor Author

Yeah. so I can start working on another UI enhancements.

@monsij
Copy link
Member

monsij commented Dec 7, 2018

You can leave out the api fields blank

@monsij
Copy link
Member

monsij commented Dec 7, 2018

Once merged..ill get them ready..do add a dummy text where these keys will go into

@harry-hov
Copy link
Contributor Author

you mean sample for using api tokens ?

Once merged..ill get them ready..do add a dummy text where these keys will go into

@monsij
Copy link
Member

monsij commented Dec 7, 2018

Yes

@harry-hov
Copy link
Contributor Author

I need time for reading Github API Documentation.

@monsij
Copy link
Member

monsij commented Dec 7, 2018

Will merge this for now

@monsij
Copy link
Member

monsij commented Dec 7, 2018

Open a separate issue for the remaining....squash your commits to get things ready

@harry-hov
Copy link
Contributor Author

done, you can merge changes now

@monsij
Copy link
Member

monsij commented Dec 7, 2018

What about these? Are these required to be committed?

Also let us know if the files under __pycache__ is required to be commited or they are just cache files

@harry-hov
Copy link
Contributor Author

What about these? Are these required to be committed?

Also let us know if the files under __pycache__ is required to be commited or they are just cache files

nope. they are just cache files

@harry-hov
Copy link
Contributor Author

let me remove those cache files and resolve conflict.

monsij
monsij requested changes Dec 7, 2018
View reviewed changes
pro1/blog/templates/blog/gitCard/medium.html Outdated
<p>@{login}</p>
<ul class="status">
<li><a href="https://github.com/{login}?tab=repositories"><strong>{public_repos}</strong>Repos</a></li>
<li><a href="https://gist.github.com/{login}/following"><strong>{following}</strong>Following</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the link for the following

@monsij monsij changed the title Contributors page Github Sync Dynamic sync for contributors page Dec 7, 2018
@harry-hov
Copy link
Contributor Author

please take a look. @monsij

monsij
monsij approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@monsij monsij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 @harry-hov

@monsij
Copy link
Member

monsij commented Dec 7, 2018 •
edited
Loading

"@gitmate-bot rebase"

@monsij
Copy link
Member

monsij commented Dec 7, 2018

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@monsij
Copy link
Member

monsij commented Dec 7, 2018

Automated rebase with GitMate.io was successful! 🎉

@monsij
Copy link
Member

monsij commented Dec 7, 2018

ack 6c69a11

@monsij monsij merged commit 2ba7f79 into NIT-DGPortal:master Dec 7, 2018
@monsij
Copy link
Member

monsij commented Dec 7, 2018

This is the last time @harry-hov that i'm merging from your master branch of fork. Please take a note of it from next time. 😅

@monsij monsij mentioned this pull request Dec 7, 2018
Closed
gutsytechster pushed a commit to gutsytechster/StudentPortal that referenced this pull request Dec 17, 2018
@harry-hov @gutsytechster
Dynamic sync for contributors page(NIT-DGPortal#33)
7d154c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsij monsij monsij approved these changes

Assignees

@harry-hov harry-hov

Labels
size/L status/approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harry-hov @monsij