Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Unwanted Comments #23

Closed
wants to merge 5 commits into from
Closed

Removed Unwanted Comments #23

wants to merge 5 commits into from

Conversation

nguptaa183
Copy link
Contributor

@nguptaa183 nguptaa183 commented Dec 6, 2018 •
edited
Loading

This removes most of the unwanted comments from the files.
Issue: #9

All Submissions:

  • Have you followed the guidelines in our Contributing document?

New Feature Submissions:

  1. Does your submission pass build tests locally?
  2. Have you indented your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

@monsij
Copy link
Member

monsij commented Dec 6, 2018

Hope that you have followed the contribution guidelines :-)

(Powered by GitMate.io)

monsij
monsij previously approved these changes Dec 6, 2018
View reviewed changes
@monsij
Copy link
Member

monsij commented Dec 6, 2018

@nguptaa : Could you include some screenshots of the changes?

monsij
monsij reviewed Dec 6, 2018
View reviewed changes
Copy link
Member

@monsij monsij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appropriate Screenshots

@monsij monsij dismissed their stale review December 6, 2018 14:38

Changes requested

monsij
monsij reviewed Dec 6, 2018
View reviewed changes
pro1/pro1/settings.py
@@ -136,7 +136,7 @@
LOGIN_URL = 'login'
LOGOUT_URL = 'logout'

#EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave out this change @nguptaa , as it has been already solved in #24 .

@nguptaa183 nguptaa183 closed this Dec 6, 2018
@nguptaa183 nguptaa183 reopened this Dec 6, 2018
@nguptaa183 nguptaa183 closed this Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsij monsij monsij left review comments

Assignees

@nguptaa183 nguptaa183

Labels
process/pending_review size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nguptaa183 @monsij