Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced new navbar #16

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Introduced new navbar #16

merged 1 commit into from
Dec 5, 2018

Conversation

harry-hov
Copy link
Contributor

Changes i did ?

1. Redesigned Navigation bar and footer

  • Before login Screen
    picture2
  • After login Screen
    picture1
  • How new navigation bar looks on mobile browser
    picture3

2. Removed about from navigation bar

Moved "about" in this logo (User just need to click on this to view site description)
screenshot 47 _li

Testing

I tested this on "localhost" using "Google Chrome" and "Microsoft Egde". Its working fine without any issues.

@monsij
Copy link
Member

monsij commented Dec 5, 2018

Hope that you have followed the contribution guidelines :-)

(Powered by GitMate.io)

@harry-hov
Copy link
Contributor Author

harry-hov commented Dec 5, 2018

All Submissions:

  • Have you followed the guidelines in our Contributing document?

New Feature Submissions:

  1. Does your submission pass build tests locally?
  2. Have you indented your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

@harry-hov
Copy link
Contributor Author

PR regarding issue #2

@monsij
Copy link
Member

monsij commented Dec 5, 2018

"@gitmate-bot rebase"

@monsij
Copy link
Member

monsij commented Dec 5, 2018

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@monsij
Copy link
Member

monsij commented Dec 5, 2018

ack 5ab3858

@monsij
Copy link
Member

monsij commented Dec 5, 2018

Automated rebase with GitMate.io was successful! 🎉

Copy link
Member

@monsij monsij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@monsij monsij merged commit 96b7149 into NIT-DGPortal:master Dec 5, 2018
@harry-hov harry-hov mentioned this pull request Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants