Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename gemini-demo.ipynb to reference_notebooks/gemini-demo.ipynb #7

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

kyleoconnell-NIH
Copy link
Contributor

Summary

Related Issues

Changes

  • Feature 1: Added the ability to do X.
  • Bug Fix: Corrected the issue where Y would fail under condition Z.
  • Refactoring: Improved the structure of component A without changing its functionality.

Testing

  • Unit tests
  • Integration tests
  • Manual testing

How to test

  1. Step 1: [Instruction]
  2. Step 2: [Instruction]
  3. Step 3: [Instruction]

Screenshots (if applicable)

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings or errors.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Notes for Reviewers

@kyleoconnell-NIH kyleoconnell-NIH requested review from jpinney32 and JohnTurnerNIH and removed request for jpinney32 October 25, 2024 19:39
Copy link
Contributor

@JohnTurnerNIH JohnTurnerNIH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to add openai to the ignore list, otherwise this is good to merge

@JohnTurnerNIH JohnTurnerNIH merged commit e3f55b4 into main Oct 28, 2024
1 check failed
@kyleoconnell-NIH kyleoconnell-NIH deleted the kyleoconnell-NIH-patch-1 branch October 30, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants