Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data request 56: Scallop Restricted areas #57

Merged
merged 6 commits into from
May 1, 2024
Merged

Data request 56: Scallop Restricted areas #57

merged 6 commits into from
May 1, 2024

Conversation

andybeet
Copy link
Member

@andybeet andybeet commented Apr 4, 2024

Files added

  • Scallop_Rotational_Areas_20230411.rda
  • Scallop_Rotational_Areas_20230411.R
  • updated pkgdown.yml

@andybeet andybeet linked an issue Apr 4, 2024 that may be closed by this pull request
2 tasks
@andybeet andybeet requested a review from jmhatch April 4, 2024 19:20
@andybeet
Copy link
Member Author

andybeet commented Apr 4, 2024

@jmhatch Not sure how you created the rds and html files for the maps section. They will need to be added

@jmhatch
Copy link
Member

jmhatch commented May 1, 2024

@andybeet Looks good! Feel free to merge this PR into dev. I made the following changes:

  • Added a leaflet map
  • Added the data_ prefix to the .R file (just to be consistent with the others)
  • Made some minor tweaks to the content of the .R file

Are you thinking to merge dev into main periodically? I think having a dev branch is a good idea, thanks for doing that.

@andybeet
Copy link
Member Author

andybeet commented May 1, 2024

@jmhatch yes. plan to merge into main. i think we should be adopting this approach branch off dev, pr to dev, pr to main

@andybeet andybeet merged commit 3f17fc9 into dev May 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Scallop rotational areas
2 participants