Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Cleanup #109

Merged
merged 21 commits into from
Dec 2, 2024
Merged

More Cleanup #109

merged 21 commits into from
Dec 2, 2024

Conversation

JacksonElia
Copy link
Member

This is mainly to address #108

The more I do this, the more necessary I realize it is. I changed like 5 comments/names that were just completely incorrect.

@JacksonElia JacksonElia added documentation Improvements or additions to documentation misc Miscellaneous changes labels Nov 28, 2024
@JacksonElia JacksonElia self-assigned this Nov 28, 2024
harshil21
harshil21 reviewed Nov 28, 2024
View reviewed changes
constants.py Outdated Show resolved Hide resolved
constants.py Outdated Show resolved Hide resolved
constants.py Outdated Show resolved Hide resolved
constants.py Show resolved Hide resolved
constants.py Outdated Show resolved Hide resolved
constants.py Outdated Show resolved Hide resolved
harshil21
harshil21 reviewed Dec 1, 2024
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cleanup of imu and main.py was definitely needed, nice job. Most of my comments are just nitpicks:

airbrakes/airbrakes.py Show resolved Hide resolved
airbrakes/data_handling/logger.py Show resolved Hide resolved
airbrakes/data_handling/logger.py Outdated Show resolved Hide resolved
airbrakes/data_handling/logger.py Show resolved Hide resolved
airbrakes/hardware/imu.py Outdated Show resolved Hide resolved
constants.py Outdated Show resolved Hide resolved
constants.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
harshil21
harshil21 reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good thing I remembered what I reviewed

airbrakes/hardware/imu.py Outdated Show resolved Hide resolved
airbrakes/hardware/imu.py Show resolved Hide resolved
@harshil21 harshil21 mentioned this pull request Dec 2, 2024
Open
@harshil21 harshil21 merged commit 0bc977a into main Dec 2, 2024
3 checks passed
@harshil21 harshil21 deleted the more-cleanup! branch December 2, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshil21 harshil21 harshil21 approved these changes

Assignees

@JacksonElia JacksonElia

Labels
documentation Improvements or additions to documentation misc Miscellaneous changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JacksonElia @harshil21