Refactor code for writing netCDF unlimited dimensions #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 87.35% 87.36% +0.02%
==========================================
Files 125 125
Lines 12887 12887
==========================================
+ Hits 11256 11258 +2
+ Misses 1631 1629 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sadielbartholomew
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code for writing netCDF unlimited dimensions: Create a wrapper method in
netcdfwrite.pyto callcfdmimplementation.nc_is_unlimited_axis, rather than than the latter being called directly. (The wrapper already existed, but was not called.)This is so that subclasses can modify the behaviour if needs be. E.g., cf-python needs to never write unlimited dimension to CFA-netCDF files.