Replace broken NASA OSM mapcache with the OSMMapnickLayer at 50% opacity #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OSM Mapnik tiles from http://a.tile.openstreetmap.org/ are fully opaque PNG tiles which makes it a base layer and unusable as an overlay. Most WWJ applications would likely prefer to use OSM as an overlay. The NASA OpenStreetMap map cache at https://worldwind20.arc.nasa.gov/mapcache served OSM overlay tiles that included transparent voids, however that server is currently returning 404 Not Found for /mapcache Using OSMMapnickLayer with a default 50% opacity is a simple substitution for the broken NASA OSM layer.
Note the NASA OSM layer configured via config/Earth/OpenStreetMap.xml points to https://worldwind20.arc.nasa.gov/mapcache which is currently returning 404 Not Found errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Why Should This Be In Core?
The default OSM layer is currently broken, creating a problem for all the demo/example apps.
Should not negatively impact any applications that use WWJ SDK.
Benefits
Minor change restores presense of a working OSM layer to all the demo/example apps.
Potential Drawbacks
OSMMapnikLayer hits a.tile.openstreetmap.org directly, including it by default would increase load on openstreetmap.org servers.
Applications that have the broken NASA OSM tileset cached locally and rely on the content of the default worldwind.layers.xml pointing to the Earth/OpenStreetMap.xml will no longer use that cached tileset. The cached NASA OSM tileset cannot be easily reused by OSMMapnikLayer because of different projections. The workaround for such applications is to retain the unchanged version of config/worldwind.layers.xml
Applicable Issues
#138