Patch for DOMXSS #892
Open
Patch for DOMXSS #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patched XSS vector through sanitizing
xss fix with ESAPI
|
Needs more testing, but I believe this is patched in this PR. |
|
Ran unit tests and it passes |
PJHogan
approved these changes
Mar 21, 2023
PJHogan
approved these changes
Mar 21, 2023
|
can we get another approver to look at this? @PJHogan? |
PJHogan
approved these changes
Mar 27, 2023
PJHogan
approved these changes
Mar 27, 2023
PJHogan
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Filling out this template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the
maintainer's discretion.
Description of the Change
Added sanitizing of append
Why Should This Be In Core?
To prevent DOMXSS.
Benefits
The benefits of this patch include extra protection against DOMXSS.
Potential Drawbacks
NA
Applicable Issues
NA